fix(dev): cosider base when special-casing /_image
#10274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 527f699 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
lilnasy
commented
Feb 29, 2024
packages/astro/src/core/request.ts
Outdated
Comment on lines
41
to
52
| if (removeParams && url.pathname !== '/_image') { | ||
| if (staticLike && url.pathname !== `${prependForwardSlash(appendForwardSlash(base))}_image`) { |
There was a problem hiding this comment.
The fix is here, the rest is clerical.
There was a problem hiding this comment.
That's very hard to read together with the template literal. Can we save the result at line 50 and then use it at line 52?
ematipico
reviewed
Feb 29, 2024
| clientAddress: buildingToSSR ? incomingRequest.socket.remoteAddress : undefined, | ||
| removeParams: buildingToSSR === false || route.prerender, | ||
| clientAddress: incomingRequest.socket.remoteAddress, | ||
| staticLike: config.output === "static" ? true : route.prerender, |
There was a problem hiding this comment.
Suggested change
| staticLike: config.output === "static" ? true : route.prerender, | |
| staticLike: config.output === "static" || route.prerender, |
packages/astro/src/core/request.ts
Outdated
Comment on lines
41
to
52
| if (removeParams && url.pathname !== '/_image') { | ||
| if (staticLike && url.pathname !== `${prependForwardSlash(appendForwardSlash(base))}_image`) { |
There was a problem hiding this comment.
That's very hard to read together with the template literal. Can we save the result at line 50 and then use it at line 52?
Princesseuh
approved these changes
Feb 29, 2024
Merged
peng
added a commit
to peng/astro
that referenced
this pull request
Mar 4, 2024
* main: (327 commits) [ci] format fix(node): listen on 0.0.0.0 if server.host is set to true (withastro#10282) [ci] format fix(dev): cosider `base` when special-casing `/_image` (withastro#10274) [ci] format update login flow to support Brave (withastro#10258) [ci] format improve link command (withastro#10257) Updates deprecated Node.js 16 github actions (withastro#10270) Fix Vitest check fail again (withastro#10266) [ci] format Adds auto completion of `astro:` events when adding or removing event listeners on `document` (withastro#10263) Update Vite to latest (withastro#10259) [ci] release (withastro#10236) [ci] format fix(i18n): localised index pages are overwritten (withastro#10250) fix: change strategy for route caching (withastro#10248) Fix TypeScript type definitions for `Code` component (withastro#10251) chang changeset (withastro#10253) Removes morph animations when setting transition:animate=none (withastro#10247) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
parseURL#10273Testing
Docs