Add new levels of notification for dev toolbar apps #10252
Conversation
🦋 Changeset detectedLatest commit: 6c936ec The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Nit: I would make the |
There was a problem hiding this comment.
This is exciting stuff! Nice work @Princesseuh 🚥
We should probably not rely only on colour for accessibility reasons — colour vision variations are really common. It's definitely a bit tricky at this scale though.
Let me know if it would be helpful for me to actually suggest something rather than just noting this!
Sure, feel free to suggest improvements! We definitely don't have a lot of room, so we can't really like, add visual text, but I'm sure we can figure something out |
|
Great suggestion @delucis! @Princesseuh here's a concept for shape + color indicators. Red circle for errors because that's what we already have. Yellow triangle for error because it's similar to a 
|
|
+1 on Nate’s suggestion! This is pretty much what I was thinking too. Not sure if the suggested blue has quite high enough contrast with the dark background? So exact colour shade might want checking, but for the general idea: two thumbs up! (Aside: I hadn’t seen GitHub displaying the colour in hex codes before — that’s cool!) |
Changes
Some users asked for the ability to show a little pill that wasn't as threatening as the red dots we have right now. This adds that.
Testing
Added a test
Docs
Will do!