-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Svelte editor tooling not working under relaxed TypeScripts projects #10244
Conversation
🦋 Changeset detectedLatest commit: 480460f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview svelte-editor-fix |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview svelte-editor-fix |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
bd5158d
to
5835dc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have done our best so far; I think it's OK to add it as peer dependency!
Changes
Svelte's tool for editor tooling (
svelte2tsx
) require TypeScript to work. A long time ago, we were able to provide it from our language server directly, but this hasn't been the case for a long time now.An alternative fix upstream would be for
svelte2tsx
to take in an instance of TypeScript, however at the moment it imports it from a bunch of top level places and it would be a significant refactor.Svelte's own tooling does not suffer from this because it's all bundled together, unlike us where Svelte's specific tooling is only in its own integration.
Fix withastro/language-tools#652
Testing
N/A
Docs
N/A