Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback URL #10228

Closed
wants to merge 2 commits into from
Closed

Fallback URL #10228

wants to merge 2 commits into from

Conversation

delucis
Copy link
Member

@delucis delucis commented Feb 25, 2024

Changes

  • Fixes PLT-1712
  • Uses same fallback URL technique in vite-plugin-db as used here:
    export function getRemoteDatabaseUrl(): string {
    const env = getAstroStudioEnv();
    return env.ASTRO_STUDIO_REMOTE_DB_URL || 'https://db.services.astro.build';
    }

Testing

  • Used this same change as a patch in a working project

Docs

n/a

Copy link

changeset-bot bot commented Feb 25, 2024

🦋 Changeset detected

Latest commit: 28254ef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@delucis
Copy link
Member Author

delucis commented Feb 26, 2024

Fixed in #10223

@delucis delucis closed this Feb 26, 2024
@delucis delucis deleted the plt-1712 branch February 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant