Skip to content

Commit

Permalink
feat: style scoped hash is lowercase (#8180)
Browse files Browse the repository at this point in the history
  • Loading branch information
ematipico authored Aug 21, 2023
1 parent 6011d52 commit f003e73
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/serious-waves-fry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': major
---

The scoped hash created by the Astro compiler is now **lowercase**.
2 changes: 1 addition & 1 deletion packages/astro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
"test:e2e:match": "playwright test -g"
},
"dependencies": {
"@astrojs/compiler": "^1.8.1",
"@astrojs/compiler": "^2.0.0",
"@astrojs/internal-helpers": "workspace:*",
"@astrojs/markdown-remark": "workspace:*",
"@astrojs/telemetry": "workspace:*",
Expand Down
4 changes: 1 addition & 3 deletions packages/astro/test/0-css.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ describe('CSS', function () {
if (/^data-astro-cid-[A-Za-z0-9-]+/.test(key)) {
// Ema: this is ugly, but for reasons that I don't want to explore, cheerio
// lower case the hash of the attribute
scopedAttribute = key
.toUpperCase()
.replace('data-astro-cid-'.toUpperCase(), 'data-astro-cid-');
scopedAttribute = key;
}
}
if (!scopedAttribute) {
Expand Down
44 changes: 41 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f003e73

Please sign in to comment.