fix: escape content module import paths (#12705)

withastro · Dec 10, 2024 · 0d1eab5 · 0d1eab5
1 parent 70cbd47
commit 0d1eab5
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/.changeset/blue-spiders-carry.md b/.changeset/blue-spiders-carry.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a bug where MDX files with certain characters in the name would cause builds to fail
diff --git a/packages/astro/src/content/mutable-data-store.ts b/packages/astro/src/content/mutable-data-store.ts
@@ -137,7 +137,7 @@ export default new Map([${exports.join(', ')}]);
 		// We then export them all, mapped by the import id, so we can find them again in the build.
 		const lines: Array<string> = [];
 		for (const [fileName, specifier] of this.#moduleImports) {
-			lines.push(`['${fileName}', () => import('${specifier}')]`);
+			lines.push(`[${JSON.stringify(fileName)}, () => import(${JSON.stringify(specifier)})]`);
 		}
 		const code = `
 export default new Map([\n${lines.join(',\n')}]);

diff --git a/...tro/test/fixtures/content-layer-rendering/content-outside-src-mdx/I'm back!.mdx b/...tro/test/fixtures/content-layer-rendering/content-outside-src-mdx/I'm back!.mdx
@@ -0,0 +1,16 @@
+---
+title: I'm back!
+description: 'Introduction to Iguana.'
+publishedDate: 'Sat May 21 2022 00:00:00 GMT-0400 (Eastern Daylight Time)'
+tags: [cats, felines]
+---
+
+import H2 from "../src/components/H2.astro";
+
+<H2>Iguana</H2>
+
+### Iguana
+
+This is a rendered entry
+
+![file](./I'm%20back.jpg)
diff --git a/...stro/test/fixtures/content-layer-rendering/content-outside-src-mdx/I'm back.jpg b/...stro/test/fixtures/content-layer-rendering/content-outside-src-mdx/I'm back.jpg