fix(#9216): fix style HMR in certain cases (#9219)

withastro · Nov 29, 2023 · 067a65f · 067a65f
1 parent 1e8d28d
commit 067a65f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/wicked-books-appear.md b/.changeset/wicked-books-appear.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fix edge case where `<style>` updates inside of `.astro` files would ocassionally fail to update without reloading the page.
diff --git a/packages/astro/src/vite-plugin-astro/hmr.ts b/packages/astro/src/vite-plugin-astro/hmr.ts
@@ -97,8 +97,8 @@ export async function handleHotUpdate(
 	// If only styles are changed, remove the component file from the update list
 	if (isStyleOnlyChange) {
 		logger.info('astro', msg.hmr({ file, style: true }));
-		// remove base file and hoisted scripts
-		return mods.filter((mod) => mod.id !== ctx.file && !mod.id?.endsWith('.ts'));
+		// Only return the Astro styles that have changed!
+		return mods.filter((mod) => mod.id?.includes('astro&type=style'));
 	}
 
 	// Add hoisted scripts so these get invalidated