fix(cloudflare): node_modules chunk #226

alexanderniebuhr · 2024-04-06T18:37:03Z

Changes

This does define a manualChunk to inline node_modules according to docs (https://rollupjs.org/configuration-options/#output-manualchunks)
closes Cloudflare v10 breaks cloudflare build / wrangler preview with React #211

Testing

manual tested on issue repo and exisiting test

Docs

bug fix, no docs needed

changeset-bot · 2024-04-06T18:37:07Z

🦋 Changeset detected

Latest commit: 13639a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@astrojs/cloudflare	Patch
@test/astro-cloudflare-astro-dev-platform	Patch
@test/astro-cloudflare-external-image-service	Patch
@test/astro-cloudflare-no-output	Patch
@test/astro-cloudflare-prerender-optimizations	Patch
@test/astro-cloudflare-routes-json	Patch
@test/astro-cloudflare-wasm	Patch
@test/astro-cloudflare-with-solid-js	Patch
@test/astro-cloudflare-wrangler-preview-platform	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alexanderniebuhr · 2024-04-06T18:37:19Z

!preview cf-deps-chunk

github-actions · 2024-04-06T18:38:05Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-deps-chunk

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-deps-chunk tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-deps-chunk-20240406183753) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 5.2.0 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-deps-chunk-20240406183753"
🦋  success packages published successfully:
🦋  @astrojs/[email protected]
🦋  Creating git tag...
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing 8c2398a1a51440fb

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing 9e927e8c8450adea

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.481s

natemoo-re

This makes sense in lieu of a more fundamental fix in core!

packages/cloudflare/src/index.ts

alexanderniebuhr · 2024-04-07T05:30:14Z

!preview cf-deps-chunk

github-actions · 2024-04-07T05:31:09Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-deps-chunk

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-deps-chunk tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-deps-chunk-20240407053056) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 5.2.0 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-deps-chunk-20240407053056"
🦋  success packages published successfully:
🦋  @astrojs/[email protected]
🦋  Creating git tag...
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing 8c2398a1a51440fb

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing d25f701ea01a9e76

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.521s

alexanderniebuhr · 2024-04-07T07:53:55Z

!preview cf-deps-chunk

github-actions · 2024-04-07T07:54:37Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-deps-chunk

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-deps-chunk tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-deps-chunk-20240407075425) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 5.2.0 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-deps-chunk-20240407075425"
🦋  success packages published successfully:
🦋  @astrojs/[email protected]
🦋  Creating git tag...
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing 8c2398a1a51440fb

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing 656d0f7ac62e7ac7

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.497s

alexanderniebuhr · 2024-04-08T12:32:40Z

!preview cf-deps-chunk

github-actions · 2024-04-08T12:33:29Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-deps-chunk

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-deps-chunk tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-deps-chunk-20240408123317) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 5.2.0 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-deps-chunk-20240408123317"
🦋  success packages published successfully:
🦋  @astrojs/[email protected]
🦋  Creating git tag...
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing 8c2398a1a51440fb

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing 778f012c2496b601

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.621s

alexanderniebuhr · 2024-04-12T12:15:25Z

@natemoo-re @ematipico thanks for your reviews, while this is a workaround which works for some cases, it does break for other cases.. I changed to draft again, to investigate further and try to find a better solution, which is more robust, even for a workaround.

alexanderniebuhr · 2024-05-08T12:48:21Z

!preview cf-deps-chunk

github-actions · 2024-05-08T12:49:12Z

Snapshots have been released for the following packages:

@astrojs/cloudflare@experimental--cf-deps-chunk

Publish Log

🦋  warn ===============================IMPORTANT!===============================
🦋  warn Packages will be released under the experimental--cf-deps-chunk tag
🦋  warn ----------------------------------------------------------------------
🦋  info npm info @astrojs/cloudflare
🦋  info npm info @astrojs/netlify
🦋  info @astrojs/cloudflare is being published because our local version (0.0.0-cf-deps-chunk-20240508124857) has not been published on npm
🦋  warn @astrojs/netlify is not being published because version 5.2.1 is already published on npm
🦋  info Publishing "@astrojs/cloudflare" at "0.0.0-cf-deps-chunk-20240508124857"
🦋  success packages published successfully:
🦋  @astrojs/[email protected]
🦋  Creating git tag...
🦋  New tag:  @astrojs/[email protected]

Build Log


> [email protected] build /home/runner/work/adapters/adapters
> turbo run build --filter="@astrojs/*"

• Packages in scope: @astrojs/cloudflare, @astrojs/netlify, @astrojs/test-utils
• Running build in 3 packages
• Remote caching disabled
::group::@astrojs/netlify:build
cache miss, executing 169fb2667cf47f89

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/netlify
> tsc

::endgroup::
::group::@astrojs/cloudflare:build
cache miss, executing 603c7009088131b1

> @astrojs/[email protected] build /home/runner/work/adapters/adapters/packages/cloudflare
> tsc

::endgroup::

 Tasks:    2 successful, 2 total
Cached:    0 cached, 2 total
  Time:    3.699s

.changeset/few-beds-dance.md

fix(cloudflare): node_modules chunk

ecbf9e1

github-actions bot added pkg: cloudflare docs pr labels Apr 6, 2024

natemoo-re approved these changes Apr 6, 2024

View reviewed changes

alexanderniebuhr commented Apr 6, 2024

View reviewed changes

packages/cloudflare/src/index.ts Show resolved Hide resolved

alexanderniebuhr added 2 commits April 6, 2024 21:14

Update packages/cloudflare/src/index.ts

0b3fa4c

fixes strange issue

d50cef9

alexanderniebuhr marked this pull request as draft April 7, 2024 07:41

use include over exclude & add experimental option

508a825

adds sharp as default

705d18f

ematipico approved these changes Apr 10, 2024

View reviewed changes

alexanderniebuhr added 3 commits April 18, 2024 08:00

Merge branch 'main' into node_module-chunk

219d43d

new solution

2df5fac

Merge branch 'main' into node_module-chunk

13639a5

alexanderniebuhr commented May 11, 2024

View reviewed changes

.changeset/few-beds-dance.md Show resolved Hide resolved

alexanderniebuhr marked this pull request as ready for review May 11, 2024 05:38

alexanderniebuhr merged commit de6f3eb into main May 11, 2024
8 checks passed

github-actions bot mentioned this pull request May 11, 2024

[ci] release #260

Merged

alexanderniebuhr deleted the node_module-chunk branch August 6, 2024 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cloudflare): node_modules chunk #226

fix(cloudflare): node_modules chunk #226

alexanderniebuhr commented Apr 6, 2024 •

edited

Loading

changeset-bot bot commented Apr 6, 2024 •

edited

Loading

alexanderniebuhr commented Apr 6, 2024

github-actions bot commented Apr 6, 2024

natemoo-re left a comment

alexanderniebuhr commented Apr 7, 2024

github-actions bot commented Apr 7, 2024

alexanderniebuhr commented Apr 7, 2024

github-actions bot commented Apr 7, 2024

alexanderniebuhr commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

alexanderniebuhr commented Apr 12, 2024

alexanderniebuhr commented May 8, 2024

github-actions bot commented May 8, 2024

fix(cloudflare): node_modules chunk #226

fix(cloudflare): node_modules chunk #226

Conversation

alexanderniebuhr commented Apr 6, 2024 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Apr 6, 2024 • edited Loading

🦋 Changeset detected

alexanderniebuhr commented Apr 6, 2024

github-actions bot commented Apr 6, 2024

natemoo-re left a comment

Choose a reason for hiding this comment

alexanderniebuhr commented Apr 7, 2024

github-actions bot commented Apr 7, 2024

alexanderniebuhr commented Apr 7, 2024

github-actions bot commented Apr 7, 2024

alexanderniebuhr commented Apr 8, 2024

github-actions bot commented Apr 8, 2024

alexanderniebuhr commented Apr 12, 2024

alexanderniebuhr commented May 8, 2024

github-actions bot commented May 8, 2024

alexanderniebuhr commented Apr 6, 2024 •

edited

Loading

changeset-bot bot commented Apr 6, 2024 •

edited

Loading