Fixed precision for double.

witgo · Apr 8, 2014 · 18aacd3 · 18aacd3
1 parent 2adb235
commit 18aacd3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
@@ -102,7 +102,10 @@ case class Cast(child: Expression, dataType: DataType) extends UnaryExpression {
   // Timestamp to long, converting milliseconds to seconds
   private def timestampToLong(ts: Timestamp) = ts.getTime / 1000
 
-  private def timestampToDouble(ts: Timestamp) = ts.getTime.toDouble / 1000
+  private def timestampToDouble(ts: Timestamp) = {
+    // First part is the seconds since the beginning of time, followed by nanosecs.
+    ts.getTime / 1000 + ts.getNanos.toDouble / 1000000000
+  }
 
   def castToLong: Any => Any = child.dataType match {
     case StringType => nullOrCast[String](_, s => try s.toLong catch {

diff --git a/.../src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala b/.../src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala
@@ -245,14 +245,14 @@ class ExpressionEvaluationSuite extends FunSuite {
   }
 
   test("timestamp casting") {
-    val millis = 15 * 1000 + 1
+    val millis = 15 * 1000 + 2
     val ts = new Timestamp(millis)
     val ts1 = new Timestamp(15 * 1000)  // a timestamp without the milliseconds part
-    checkEvaluation(ts cast ShortType, 15)
-    checkEvaluation(ts cast IntegerType, 15)
-    checkEvaluation(ts cast LongType, 15)
-    checkEvaluation(ts cast FloatType, 15.001f)
-    checkEvaluation(ts cast DoubleType, 15.001)
+    checkEvaluation(Cast(ts, ShortType), 15)
+    checkEvaluation(Cast(ts, IntegerType), 15)
+    checkEvaluation(Cast(ts, LongType), 15)
+    checkEvaluation(Cast(ts, FloatType), 15.002f)
+    checkEvaluation(Cast(ts, DoubleType), 15.002)
     checkEvaluation(Cast(Cast(ts, ShortType), TimestampType), ts1)
     checkEvaluation(Cast(Cast(ts, IntegerType), TimestampType), ts1)
     checkEvaluation(Cast(Cast(ts, LongType), TimestampType), ts1)
@@ -261,6 +261,9 @@ class ExpressionEvaluationSuite extends FunSuite {
     checkEvaluation(Cast(Cast(millis.toDouble / 1000, TimestampType), DoubleType),
       millis.toDouble / 1000)
     checkEvaluation(Cast(Literal(BigDecimal(1)) cast TimestampType, DecimalType), 1)
+
+    // A test for higher precision than millis
+    checkEvaluation(Cast(Cast(0.00000001, TimestampType), DoubleType), 0.00000001)
   }
 }