Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFF-465 Add getUserKey logic to prebid.js adapter #3

Merged
merged 3 commits into from
Apr 27, 2023
Merged

OFF-465 Add getUserKey logic to prebid.js adapter #3

merged 3 commits into from
Apr 27, 2023

Conversation

mike-lei
Copy link

@mike-lei mike-lei commented Apr 16, 2023 •
edited
Loading

Get user key from cookies
Add cookie sync Cookie sync in the adapter would cause double sync

jpanduro-blackbird
jpanduro-blackbird requested changes Apr 25, 2023
View reviewed changes
modules/flippBidAdapter.js Outdated
}
}

const FLIPP_USER_KEY = 'flipp-uid';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put all constants on the top

modules/flippBidAdapter.js Outdated
}

// If the partner provides the user key use it, otherwise fallback to cookies
if ('userKey' in options && options.userKey) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ('userKey' in options && options.userKey) {
if (options.userKey) {

modules/flippBidAdapter.js Outdated
// Generate if none found
userKey = generateUUID();

if (!userKey) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that it will be some empty value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to have empty user key if everything fails, kevel request would still work without a key
Updated the branch to return empty string instead of null anyway

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I haven't described well, I meant in general, do we need this check rather then what's the default value of this condition.
Looks like generateUUID always returns string, that's was my question.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, just removed the check

@mike-lei mike-lei merged commit 302de4d into master Apr 27, 2023
@mike-lei mike-lei deleted the off-465 branch April 27, 2023 15:44
mike-lei added a commit that referenced this pull request Oct 18, 2023
@mike-lei @jpanduro-blackbird
Flipp Bid Adapter : initial release (prebid#10412)
e626373 
* Flipp Bid Adapter: initial release

* Added flippBidAdapter

* OFF-372 Support DTX/Hero in flippBidAdapter (#2)

* support creativeType

* OFF-422 flippBidAdapter handle AdTypes

---------

Co-authored-by: Jairo Panduro <[email protected]>

* OFF-465 Add getUserKey logic to prebid.js adapter (#3)

* Support cookie sync and uid

* address pr feedback

* remove redundant check

* OFF-500 Support "startCompact" param for Prebid.JS #4

* set startCompact default value (#5)

* fix docs

* use client bidding endpoint

* update unit testing endpoint

---------

Co-authored-by: Jairo Panduro <[email protected]>
mike-lei added a commit that referenced this pull request Nov 30, 2023
@mike-lei @jpanduro-blackbird
Flipp Bid Adapter: add additional check for userKey value, update docs (
54e5cb1 
prebid#10628)

* Flipp Bid Adapter: initial release

* Added flippBidAdapter

* OFF-372 Support DTX/Hero in flippBidAdapter (#2)

* support creativeType

* OFF-422 flippBidAdapter handle AdTypes

---------

Co-authored-by: Jairo Panduro <[email protected]>

* OFF-465 Add getUserKey logic to prebid.js adapter (#3)

* Support cookie sync and uid

* address pr feedback

* remove redundant check

* OFF-500 Support "startCompact" param for Prebid.JS #4

* set startCompact default value (#5)

* fix docs

* use client bidding endpoint

* update unit testing endpoint

* OFF-876 [Prebid Adapter] Check userKey for empty string (#6)

* add more checks to userKey

* update document

* add uuid format statement

* modify docs

---------

Co-authored-by: Jairo Panduro <[email protected]>
mike-lei added a commit that referenced this pull request May 30, 2024
@mike-lei @jpanduro-blackbird
Flipp Bid Adapter: update constant NETWORK_ID (prebid#10781)
2de3f87 
* Flipp Bid Adapter: initial release

* Added flippBidAdapter

* OFF-372 Support DTX/Hero in flippBidAdapter (#2)

* support creativeType

* OFF-422 flippBidAdapter handle AdTypes

---------

Co-authored-by: Jairo Panduro <[email protected]>

* OFF-465 Add getUserKey logic to prebid.js adapter (#3)

* Support cookie sync and uid

* address pr feedback

* remove redundant check

* OFF-500 Support "startCompact" param for Prebid.JS #4

* set startCompact default value (#5)

* fix docs

* use client bidding endpoint

* update unit testing endpoint

* OFF-876 [Prebid Adapter] Check userKey for empty string (#6)

* add more checks to userKey

* update document

* add uuid format statement

* modify docs

* fix network id

---------

Co-authored-by: Jairo Panduro <[email protected]>
mike-lei pushed a commit that referenced this pull request May 30, 2024
@PavloMalashnyak
Blockthrough Bid Adapter: initial release (prebid#10870)
ab7068e 
* PE-87: Implement Prebid Adapter (#1)

* PE-87: implement BT Bid Adapter

* PE-87: rework adapter to use ortbConverter lib, make requested changes

* PE-87: update imports

* PE-110: Add user sync logic to the Prebid Adapter (#3)

* PE-110: add user sync logic

* PE-110: update userSync url

* PE-110: check if iframe is enabled before setting params

* PE-111: BT Prebid Adapter can request AA ads or regular ads (#2)

* PE-120: Send Prebid Bidder info to BT Server (#4)

* PE-120: add btBidderCode to the bid object

* PE-120: use single quotes for logs string

* PE-123: Add More Metadata in site.ext.blockthrough (#5)

* PE-123: send additional meta data

* PE-123: send auctionID under imp.ext.prebid.blockthrough

* PE-123: use ortb2 config to set site.ext params

* PE-123: sent auctionId in ext.prebid.blockthrough.auctionID

* PE-123: update logs for bidderConfig setup

* PE-000: check if blockthrough is defined (#6)

* PE-87: remove BT specific logic (#7)

* Implement Blockthrough Prebid Adapter

* PE-87: Implement Prebid Adapter - misc fixes (prebid#9)

* PE-87: rename test file, add bidder config

* PE-87: increase ttl

* PE-000: fix test

* BP-74: Change the way we enable debug (prebid#10)

* BP-79: Send GPID as a part of `imp[].ext` (prebid#11)

* BP-79: send gpid in imp.ext

* BP-79: add optional operator

* BP-90: Update Cookie Sync Logic (prebid#12)

* BP-90: pass bidder to cookie sync

* BP-90: update sync logic, fix typo

* BP-90: use const for syncs variable

* BP-55: Re-add endpoint URLs (prebid#13)

* BP-91: Add prebid JS version to auction request (prebid#14)
mike-lei pushed a commit that referenced this pull request May 30, 2024
@pashaGhub @eldzis
setupad Bid Adapter: initial commit (prebid#11008)
48113b1 
* create setupadBidAdapter

* add setupadBidAdapter

* update setupadBidAdapter

* update metrics collection

* update analytics collection

* update getUserSyncs

* add setupadAnalyticsAdapter.js

* test setupadAnalyticsAdapter

* remove test: 1

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* clean up && seat bugfix

* clean up logs

* add userID module handling

* update md && clean up

* Send setupad only on bidRequested

* Fix bidResponse and bidWon responses

* Improve bidResponse and bidWon logic

* Revert changes to specific files

* Remove test parameter

* Fix multiple bidResponse and bidTimeout calls to getPixelUrl

* eslint errors fixes(brackets added)

* Add extra checks for events

* Fix BIDDER_CODE const

* update reporting endpoint

* update setupadBidAdapter_spec.js REPORT_ENDPOINT

* update readme

* Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

* Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* # This is a combination of 20 commits.
# This is the 1st commit message:

add setupadBidAdapter

# This is the commit message #2:

update setupadBidAdapter

# This is the commit message #3:

update metrics collection

# This is the commit message #4:

update analytics collection

# This is the commit message #5:

update getUserSyncs

# This is the commit message #6:

add setupadAnalyticsAdapter.js

# This is the commit message #7:

test setupadAnalyticsAdapter

# This is the commit message #8:

remove test: 1

# This is the commit message prebid#9:

add GVLID && bug fixes && test updates

# This is the commit message prebid#10:

remove setupadAnalyticsAdapter

# This is the commit message prebid#11:

add userID module handling

# This is the commit message prebid#12:

clean up && seat bugfix

# This is the commit message prebid#13:

add userID module handling

# This is the commit message prebid#14:

add GVLID && bug fixes && test updates

# This is the commit message prebid#15:

remove setupadAnalyticsAdapter

# This is the commit message prebid#16:

add userID module handling

# This is the commit message prebid#17:

clean up logs

# This is the commit message prebid#18:

update md && clean up

# This is the commit message prebid#19:

Send setupad only on bidRequested

# This is the commit message prebid#20:

Fix bidResponse and bidWon responses

* # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a
parent cecfce3
author pavel <[email protected]> 1706627437 +0200
committer pavel <[email protected]> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message prebid#22:

Remove test parameter

* # This is a combination of 26 commits.
parent cecfce3
author pavel <[email protected]> 1706627437 +0200
committer pavel <[email protected]> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message prebid#22:

Remove test parameter

# This is the commit message prebid#23:

Fix multiple bidResponse and bidTimeout calls to getPixelUrl

# This is the commit message prebid#25:

eslint errors fixes(brackets added)

# This is the commit message prebid#26:

Add extra checks for events

* parent 75178b9
author pavel <[email protected]> 1706627694 +0200
committer pavel <[email protected]> 1706627694 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC
 s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ
 b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI
 DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY
 Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK
 buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp
 lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o
 Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR
 lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS
 OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0
 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH
 AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA=
 =Gbog
 -----END PGP SIGNATURE-----

bugfixes

update setupadBidAdapter_spec.js REPORT_ENDPOINT

update readme

Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* change double quote to single quote

---------

Co-authored-by: pavel <[email protected]>
Co-authored-by: Elgars Grodnis <[email protected]>

* bugfix setupadBidAdapter

remove getAdEl, spelling correction

* add onBidWon event

onBidWon event handling moved from custom to native onBidWon method

* minor bugfixes && remove funk getSiteObj && getDeviceObj

---------

Co-authored-by: pavel <[email protected]>
Co-authored-by: Elgars Grodnis <[email protected]>
mike-lei pushed a commit that referenced this pull request May 30, 2024
@giuseppe-exads @tfoliveira
EXADS Bid Adapter: initial release (prebid#11284)
8c72bc2 
* First commit

* fix: readme.md

* fix: changed exads urls

* fix: Tools and suggestions related to the doc

* fix: from code review

* fix: from code review

* fix: from code review

* fix: error from code review - native example

* fox: from code review

* fix: from code review

* fix: from code review

* fix: native img set as mandatory

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: bidfloor and bidfloorcur set as optional

* fix: dsa

* fix: mananing multiple responses

* fix: unit test after code review

* fix: fixing native snippet code

* fix: from code review

* fix: video events after code review

* fix: video module into documentation

* fix: impression tracker for native

* fix: afeter code review

* fix: unit tests

* fix: added badv and bcat

* fix: video -> mimes and protocols

* fix

* fix: removed image_output and video_output params, forcing always html for rtb banner

* fix: gulp

* fix: added site.name

* fix: removed EXADS dir

* fix: after linting

* fix: unit tests

* fix: final dsa solution

* fix: dsa

* fix: fix instream example

* fix: doc media type context

* fix: documented the endpoint param into native section

* fix: related to markdown lint validation (#2)

* fix: from CR (#3)

---------

Co-authored-by: tfoliveira <[email protected]>
mike-lei pushed a commit that referenced this pull request May 30, 2024
@giuseppe-exads @tfoliveira
EXADS Bid Adapter : update bidder code before adapter is published (p…
8c5c9d5 
…rebid#11464)

* First commit

* fix: readme.md

* fix: changed exads urls

* fix: Tools and suggestions related to the doc

* fix: from code review

* fix: from code review

* fix: from code review

* fix: error from code review - native example

* fox: from code review

* fix: from code review

* fix: from code review

* fix: native img set as mandatory

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: from code review

* fix: bidfloor and bidfloorcur set as optional

* fix: dsa

* fix: mananing multiple responses

* fix: unit test after code review

* fix: fixing native snippet code

* fix: from code review

* fix: video events after code review

* fix: video module into documentation

* fix: impression tracker for native

* fix: afeter code review

* fix: unit tests

* fix: added badv and bcat

* fix: video -> mimes and protocols

* fix

* fix: removed image_output and video_output params, forcing always html for rtb banner

* fix: gulp

* fix: added site.name

* fix: removed EXADS dir

* fix: after linting

* fix: unit tests

* fix: final dsa solution

* fix: dsa

* fix: fix instream example

* fix: doc media type context

* fix: documented the endpoint param into native section

* fix: related to markdown lint validation (#2)

* fix: from CR (#3)

* fix: changed bidder code to exads

* fix: userAgent

---------

Co-authored-by: tfoliveira <[email protected]>
mike-lei added a commit that referenced this pull request May 30, 2024
@mike-lei @jpanduro-blackbird
OFF-1455 [Prebid.js] height should use the compactHeight and standard…
e6506e7 
…Height fields in decisions response (#8)

* Flipp Bid Adapter: initial release

* Added flippBidAdapter

* OFF-372 Support DTX/Hero in flippBidAdapter (#2)

* support creativeType

* OFF-422 flippBidAdapter handle AdTypes

---------

Co-authored-by: Jairo Panduro <[email protected]>

* OFF-465 Add getUserKey logic to prebid.js adapter (#3)

* Support cookie sync and uid

* address pr feedback

* remove redundant check

* OFF-500 Support "startCompact" param for Prebid.JS #4

* set startCompact default value (#5)

* fix docs

* use client bidding endpoint

* update unit testing endpoint

* OFF-876 [Prebid Adapter] Check userKey for empty string (#6)

* add more checks to userKey

* update document

* add uuid format statement

* modify docs

* fix network id

* use compactHeight and standardHeight in customData

---------

Co-authored-by: Jairo Panduro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpanduro-blackbird jpanduro-blackbird jpanduro-blackbird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-lei @jpanduro-blackbird