Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove code duplication but still keeping neuron_*.py #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

takipipo
Copy link
Collaborator

@takipipo takipipo commented Dec 19, 2024

Refactor

TODO

  • Remove neuron_*.py
  • Test exporting and loading NeuronX and Neuron models using YOLO

@takipipo
Copy link
Collaborator Author

@nirattisai-t @luangtatipsy Please consider this PR from the review of ultralytics#18199

Copy link

@nirattisai-t nirattisai-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takipipo
Copy link
Collaborator Author

takipipo commented Dec 24, 2024

@nirattisai-t could you test the following becuase this might effect the way kirin libraries use wisesight:ultralytics

TODO

  • Remove neuron_*.py (ลบไฟล์ที่สร้างขึ้นมาออกให้หมด)
  • Test exporting and loading NeuronX and Neuron models using YOLO (เรียก method ทุกอย่างผ่าน YOLO แทน)

something like this

from ultralytics import YOLO

model = YOLO("yolov8l.pt")
model.export(format="neuronx")
# model.export(format="neuron")

neuron_model = YOLO("yolov8l.neuronx")
# neuron_model = YOLO("yolov8l.neuron")

@nirattisai-t
Copy link

Okie, I will recheck those tests again if it works or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants