Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] "hide_disconnected_pins" ignores "loops" #263

Closed
nataloko opened this issue Dec 20, 2021 · 2 comments
Closed

[bug] "hide_disconnected_pins" ignores "loops" #263

nataloko opened this issue Dec 20, 2021 · 2 comments

Comments

@nataloko
Copy link

When I enable the "hide_disconnected_pins" option on a connector with loops, I get a series of warnings (nod XX, port YY unrecognized) and the a wiring artefact on the drawing.

XQI2fn2klt
kvid added a commit to kvid/WireViz that referenced this issue Dec 28, 2021
@kvid
Make sure loop connected pins are not hidden
6d551e7 
Resolves wireviz#263 that describes warnings and weird loop drawing because
loop connected pins are hidden when hide_disconnected_pins=True.
@kvid kvid mentioned this issue Dec 28, 2021
Merged
@kvid
Copy link
Collaborator

kvid commented Dec 28, 2021

Thank you for reporting this bug. Please try my fix in PR #264 and make a review or comment about what you find. Does it resolve your issue fully?

@kvid kvid changed the title "hide_disconnected_pins" ignores "loops" [bug] "hide_disconnected_pins" ignores "loops" Dec 29, 2021
@nataloko
Copy link
Author

The fix works great thanks :)

kvid added a commit to kvid/WireViz that referenced this issue Jan 24, 2022
@kvid
Activate loop pins earlier
504fb73 
Bug: When connector.additional_components.qty_multiplier=populated,
then the number of connected pins are counted before loop pins are
activated; hence the count is wrong.

Fix: Move loop pins activation to the Connector class for earlier
execution. The main issue is still resolved, and now in a way that
avoids the bug described above.

Resolves wireviz#263 that describes warnings and weird loop drawing because
loop connected pins are hidden when hide_disconnected_pins=True.
kvid added a commit to kvid/WireViz that referenced this issue Sep 1, 2023
@kvid
Make sure loop connected pins are not hidden (wireviz#264)
6aa0c58 
- Resolves wireviz#263 that describes warnings and weird loop drawing because
  loop connected pins are hidden when hide_disconnected_pins=True.

- Activate loop pins as early as possible to enable correct counting of
  connected pins when
  connector.additional_components.qty_multiplier=populated.

- Check that loop pins actually exist before activating them.
kvid added a commit to kvid/WireViz that referenced this issue Sep 2, 2023
@kvid
Make sure loop connected pins are not hidden (wireviz#264)
9a39de0 
- Resolves wireviz#263 that describes warnings and weird loop drawing because
  loop connected pins are hidden when hide_disconnected_pins=True.

- Activate loop pins as early as possible to enable correct counting of
  connected pins when
  connector.additional_components.qty_multiplier=populated.

- Check that loop pins actually exist before activating them.
@martinrieder martinrieder mentioned this issue Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvid @nataloko