Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csvjoin: Implement case-insensitive key comparison #610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anorth
Copy link

@anorth anorth commented May 24, 2016

This is much nicer than lowercasing files to do the join then trying to restore case that's important later on.

Thanks for the great tools!

@@ -10,3 +10,4 @@ docs/_build
.coverage
.tox
cover
env
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for a virtualenv, but let me know if you have another convention you strongly prefer.

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage decreased (-0.1%) to 87.099% when pulling a4f93c7 on dssrt:master into ffe5f44 on wireservice:master.

@jpmckinney
Copy link
Member

Instead of making this an option that only applies to csvjoin, I think it we could use a global option to normalize headers. This relates to #525, which needs to normalize headers to be SQL-safe.

@jpmckinney jpmckinney changed the title Implement case-insensitive key comparison for csvjoin csvjoin: Implement case-insensitive key comparison Aug 4, 2017
lcorbasson pushed a commit to lcorbasson/csvkit that referenced this pull request Sep 7, 2020
@fgregg
Copy link
Contributor

fgregg commented Jul 20, 2023

@jpmckinney this PR doesn't actually seem to be about headers?

@jpmckinney
Copy link
Member

@fgregg You're right - not sure what I was thinking in 2016 😅

@jpmckinney jpmckinney force-pushed the master branch 3 times, most recently from 709f226 to e5ef16e Compare October 18, 2023 03:18
@jpmckinney
Copy link
Member

@fgregg Is this the sort of think that csvlink does? I'd be happy to add a note to csvjoin, instead of adding lowercase (which i just one possible transformation to assist in linking tables).

@fgregg
Copy link
Contributor

fgregg commented Oct 18, 2023

csvlink is not a good fit for this. one thing i’ve often wished for is passing a little code into csvpy on the command line that could make this really composable

something like csvpy -c identifier -p “d.lower()” example.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants