Skip to content

Commit

Permalink
Revert "fix: Allow consecutive calls to Table.group_by, closes #765"
Browse files Browse the repository at this point in the history
  • Loading branch information
jpmckinney committed Oct 4, 2023
1 parent 5021bd5 commit 5998a83
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Unreleased

* feat: Lowercase the ``null_values`` provided to individual data types, since all comparisons to ``null_values`` are case-insensitive. (#770)
* feat: :class:`.Mean` works with :class:`.TimeDelta`. (#761)
* fix: Allow consecutive calls to :meth:`.Table.group_by`. (#765)

1.7.1 - Jan 4, 2023
-------------------
Expand Down
7 changes: 1 addition & 6 deletions agate/tableset/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,7 @@ def _proxy(self, method_name, *args, **kwargs):
tables = []

for key, table in self.items():
result = getattr(table, method_name)(*args, **kwargs)
if isinstance(result, TableSet):
for table in result.values():
tables.append(table)
else:
tables.append(result)
tables.append(getattr(table, method_name)(*args, **kwargs))

return self._fork(
tables,
Expand Down
5 changes: 0 additions & 5 deletions tests/test_table/test_group_by.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,3 @@ def test_group_by_bad_column(self):

with self.assertRaises(KeyError):
table.group_by('bad')

def test_group_by_twice(self):
table = Table(self.rows, self.column_names, self.column_types)

repr(table.group_by('one').group_by('two'))

0 comments on commit 5998a83

Please sign in to comment.