Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --root-dir propagation to the standalone server #101

Merged

Conversation

simonjgould
Copy link
Contributor

@simonjgould simonjgould commented Nov 15, 2023

Closes #100 & #96

References

Submitter checklist

  • [ x] Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • [ x] The PR request is well described and justified, including the body and the references
  • [ x] The PR title represents the desired changelog entry
  • [ x] The repository's code style is followed (see the contributing guide)
  • [ x] Test coverage that demonstrates that the change works as expected
  • [ x] For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry that I missed the PR

@oleg-nenashev oleg-nenashev changed the title fixed command arg for --root-dir in standalone server Fix --root-dir propagation to the standalone server Dec 12, 2023
@oleg-nenashev
Copy link
Member

I will fix the integration tests in the Master branch

@oleg-nenashev oleg-nenashev merged commit 461dcf3 into wiremock:master Dec 12, 2023
6 of 7 checks passed
@abdusahin
Copy link

hi @oleg-nenashev , I'm facing this issue, is there an ETA for failing integration tests ? latest tag 2.6.1 doesn't include the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root_dir broken for wiremock standalone server
3 participants