Refactor CSV export #4293
Open
Refactor CSV export #4293
+594
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
team-info-stern
branch
2 times, most recently
from
19c4ac0
to
81fcc17
Compare
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
team-info-stern
branch
from
81fcc17
to
5c4b3e5
Compare
2 tasks
This is not needed anymore since the stern endpoint to get user activity has been removed.
pcapriotti
force-pushed
the
team-info-stern
branch
from
39f74ce
to
963b33b
Compare
mdimjasevic
reviewed
Oct 17, 2024
services/brig/src/Brig/Data/User.hs
Outdated
| @@ -374,6 +374,7 @@ lookupName u = | |||
| fmap runIdentity | |||
| <$> retry x1 (query1 nameSelect (params LocalQuorum (Identity u))) | |||
|
|
|||
| -- TODO: remove this | |||
There was a problem hiding this comment.
Something still to be done?
mdimjasevic
reviewed
Oct 17, 2024
| case mFromInvitation of | ||
| Just ts -> pure $ Just ts | ||
| Nothing -> do | ||
| -- TODO: make this a single user query |
There was a problem hiding this comment.
Is this still to be done or you've changed your mind?
mdimjasevic
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
last_activeandstatuscolumns to the team CSV export. It also includes a refactoring of the export handler. I manually tested performance of the new handler, and for 500 users it's very similar to before despite the extra query. For larger teams it should be comparatively faster.We have had a discussion on whether or not to make a new version of this endpoint. Adding columns at the end of the previous CSV format is quite unlikely to break scripts, so in the end I decided not to make a new version and keep things simple. In the future, we might consider further improving the export functionality by making it asynchronous for large teams, and possibly making columns user-selectable.
https://wearezeta.atlassian.net/browse/WPB-11368
Checklist
changelog.d