Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve libzauth ACL syntax #2714

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Improve libzauth ACL syntax #2714

merged 6 commits into from
Sep 23, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 20, 2022 •
edited
Loading

This PR replaces the prefix-tree matcher used in libzauth for matching ACL paths with a simple regex-based matcher, which constructs a single regular expression containing all possible paths. This makes it trivial to accept user-provided regular expressions in the ACL language itself.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 09:59 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 09:59 Inactive
@pcapriotti pcapriotti marked this pull request as ready for review September 20, 2022 09:59
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 09:59 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 09:59 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 20, 2022
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 11:16 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 11:16 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 11:38 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 20, 2022 11:38 Inactive
@elland
Copy link
Contributor

elland commented Sep 21, 2022

Ignore if unrelated, but would this be a good place to also deal with #2660?

@pcapriotti
Copy link
Contributor Author

Ignore if unrelated, but would this be a good place to also deal with #2660?

I don't think so, it's pretty much unrelated, as this PR only affects the rust library and the change is mostly internal and backwards compatible. Moving installed files around requires some extra care.

@smatting smatting self-requested a review September 23, 2022 09:23
@pcapriotti pcapriotti merged commit 74632d7 into develop Sep 23, 2022
@pcapriotti pcapriotti deleted the pcapriotti/improve-acl branch September 23, 2022 09:35
This was referenced Sep 23, 2022
Merged
Merged
@zebot zebot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @elland @smatting @zebot