Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for HLS not finding files while running template haskell #2388

Merged
merged 1 commit into from
May 12, 2022
Merged

Workaround for HLS not finding files while running template haskell #2388

merged 1 commit into from
May 12, 2022
+6 −3

Conversation

akshaymankar
Copy link
Member

haskell/haskell-language-server#481

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • No Changelog

@akshaymankar akshaymankar requested a review from pcapriotti May 12, 2022 08:37
@akshaymankar akshaymankar temporarily deployed to cachix May 12, 2022 08:37 Inactive
elland
elland reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the solution, but I'm also not aware of a better one… 😰

@akshaymankar akshaymankar force-pushed the akshaymankar/hls-workaround branch from 84a8f6b to f51dc3c Compare May 12, 2022 09:05
@akshaymankar akshaymankar temporarily deployed to cachix May 12, 2022 09:05 Inactive
@akshaymankar akshaymankar merged commit 98992af into develop May 12, 2022
@akshaymankar akshaymankar deleted the akshaymankar/hls-workaround branch May 12, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland elland left review comments

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @pcapriotti @elland