Import http2 fix #1582
Merged
Import http2 fix #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaymankar
reviewed
Jun 9, 2021
jschaul
reviewed
Jun 9, 2021
Done: kazu-yamamoto/http2#28 |
jschaul
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue we were experiencing with end2end tests randomly failing on CI. The underlying problem is that the nginx controller proxying the federator uses an HTTP2 feature which was implemented incorrectly in the http2 library, which we indirectly depend on. See kazu-yamamoto/http2#27.
This imports a fix from our fork into our stackage snapshot.