Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calling survey countly events - WPB-11629 #2051

Merged
merged 16 commits into from
Oct 17, 2024

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Oct 16, 2024

BugWPB-11629 Rework call survey events

Issue

Since we reworked the setup for analytics, the calling survey was not functional and produced a crash when accessing deprecated implementation Analytics.shared.

Solution

  • remove all old code about Analytics and AnalyticsType
  • move existing logic to AnalyticsTrackingEvent
  • add usecase to wrap the CallSurveyEvent invocation to expose it to Wire-iOS

Testing

  1. Initiate call on A
  2. Answer on B and answer form

Screenshot 2024-10-16 at 22 32 45

Screenshot 2024-10-16 at 22 53 27


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Results

    1 files    257 suites   8m 46s ⏱️
2 396 tests 2 394 ✅ 0 💤 2 ❌
2 402 runs  2 395 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 1f55919.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 16, 2024

Datadog Report

Branch report: fix/WPB-11629-calling-survey-events
Commit report: 5344df6
Test service: wire-ios-mono

❌ 1 Failed (0 Known Flaky), 2395 Passed, 0 Skipped, 1m 8.53s Total Time
❄️ 1 New Flaky

❌ Failed Tests (1)

  • testThatItDoesNotRemoveUsersWithDifferentIds - WireDataModelTests.DatabaseMigrationTests_UserUniqueness - Details

    Expand for error
     XCTAssertEqual failed: ("0") is not equal to ("1")
     
     wire-ios-data-model/Tests/Source/ManagedObjectContext/DatabaseMigrationTests+UserUniqueness.swift:76
    

New Flaky Tests (1)

  • test_CommitPendingProposals_MultipleCommits - WireDataModelTests.MLSServiceTests - Last Failure

    Expand for error
     XCTAssertEqualWithAccuracy failed: ("-0.0004140138626098633") is not equal to ("-23.56390106678009") +/- ("0.1")
     
     wire-ios-data-model/Tests/MLS/MLSServiceTests.swift:1123
    

Copy link
Contributor

@agisilaos agisilaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you @netbe!

@agisilaos agisilaos self-requested a review October 17, 2024 08:04
@netbe netbe merged commit 8942a84 into epic/analytics-wpb-8911 Oct 17, 2024
9 of 11 checks passed
@netbe netbe deleted the fix/WPB-11629-calling-survey-events branch October 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants