-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calling survey countly events - WPB-11629 #2051
fix: calling survey countly events - WPB-11629 #2051
Conversation
WireAnalytics not exposed to Wire-iOS
Test Results 1 files 257 suites 8m 46s ⏱️ For more details on these failures, see this check. Results for commit 1f55919. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 2395 Passed, 0 Skipped, 1m 8.53s Total Time ❌ Failed Tests (1)
New Flaky Tests (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thank you @netbe!
WireAnalytics/Sources/WireAnalytics/Events/AnalyticsEvent+Predefined.swift
Outdated
Show resolved
Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Segmentation/SegmentationEntry+Predefined.swift
Outdated
Show resolved
Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Segmentation/SegmentationEntry+Predefined.swift
Outdated
Show resolved
Hide resolved
WireAnalytics/Sources/WireAnalytics/Events/Segmentation/SegmentationEntry+Predefined.swift
Outdated
Show resolved
Hide resolved
wire-ios-sync-engine/Source/Use cases/CallQualitySurveyUseCase.swift
Outdated
Show resolved
Hide resolved
…tationEntry+Predefined.swift Co-authored-by: John Nguyen <[email protected]>
…tationEntry+Predefined.swift Co-authored-by: John Nguyen <[email protected]>
….swift Co-authored-by: John Nguyen <[email protected]>
…tationEntry+Predefined.swift Co-authored-by: John Nguyen <[email protected]>
Issue
Since we reworked the setup for analytics, the calling survey was not functional and produced a crash when accessing deprecated implementation
Analytics.shared
.Solution
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: