Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TODOs and tests in WireUI - WPB-11346 #2011

Merged
merged 19 commits into from
Oct 10, 2024
Merged

fix: TODOs and tests in WireUI - WPB-11346 #2011

merged 19 commits into from
Oct 10, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 9, 2024 •
edited by github-actions bot
Loading

BugWPB-11346 [iOS] Resolve TODOs and fix tests

Issue

Fixes the remaining TODOs and makes CI pass.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian changed the base branch from develop to epic/navigation-overhaul-WPB-6647 October 9, 2024 13:01
@echoes-hq echoes-hq bot added echoes: features End-user visible changes intended to create customer value echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Test Results

61 tests   61 ✅  35s ⏱️
18 suites   0 💤
 1 files     0 ❌

Results for commit da804c9.

♻️ This comment has been updated with latest results.

@caldrian caldrian marked this pull request as ready for review October 9, 2024 17:41
@caldrian caldrian changed the title fix: TODOs and tests - WPB-11346 fix: TODOs and tests in WireUI - WPB-11346 Oct 10, 2024
@caldrian caldrian merged commit 58feeb5 into epic/navigation-overhaul-WPB-6647 Oct 10, 2024
14 of 17 checks passed
@caldrian caldrian deleted the fix/resolve-TODOs-WPB-11346 branch October 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caldrian caldrian

Labels
echoes: features End-user visible changes intended to create customer value echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caldrian