Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: present connect screen as modal - WPB-11394 #2002

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 7, 2024

BugWPB-11394 [iPad] Display the new conversation/connect screen modally

Issue

The connect/new conversation screen should not be embedded into the split view controller but be presented modally.
This PR fixes it.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Test Results

    2 files    273 suites   8m 54s ⏱️
2 474 tests 2 472 ✅ 0 💤 2 ❌
2 476 runs  2 472 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 67daac5.

♻️ This comment has been updated with latest results.

@caldrian caldrian marked this pull request as draft October 7, 2024 08:57
@caldrian caldrian marked this pull request as ready for review October 7, 2024 09:23
@caldrian caldrian merged commit 89f874d into epic/navigation-overhaul-WPB-6647 Oct 7, 2024
5 of 10 checks passed
@caldrian caldrian deleted the fix/connect-screen-as-modal-WPB-11394 branch October 7, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant