-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: present connect screen as modal - WPB-11394 #2002
Merged
caldrian
merged 34 commits into
epic/navigation-overhaul-WPB-6647
from
fix/connect-screen-as-modal-WPB-11394
Oct 7, 2024
Merged
fix: present connect screen as modal - WPB-11394 #2002
caldrian
merged 34 commits into
epic/navigation-overhaul-WPB-6647
from
fix/connect-screen-as-modal-WPB-11394
Oct 7, 2024
+729
−1,208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/wire-ios into fix/connect-screen-as-modal-WPB-11394
…p/wire-ios into fix/connect-screen-as-modal-WPB-11394
…p/wire-ios into fix/connect-screen-as-modal-WPB-11394
echoes-hq
bot
added
the
echoes: features
End-user visible changes intended to create customer value
label
Oct 7, 2024
Test Results 2 files 273 suites 8m 54s ⏱️ For more details on these failures, see this check. Results for commit 67daac5. ♻️ This comment has been updated with latest results. |
caldrian
merged commit Oct 7, 2024
89f874d
into
epic/navigation-overhaul-WPB-6647
5 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The connect/new conversation screen should not be embedded into the split view controller but be presented modally.
This PR fixes it.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: