Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create double column container to fix portrait mode - WPB-10140 #1997

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 2, 2024

StoryWPB-10140 [iOS][iPad] Sidebar - Conversations

Issue

In portrait mode we would like to show the sidebar as overlay, but the conversation list still next to the conversation.
This is currently not supported by UISplitViewController.
This PR creates a custom double column split/container view controller and sets the UISplitViewController's mode to .doubleColumn.

Testing

Rotate the device, use stage manager to resize the app's window.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian changed the base branch from develop to epic/navigation-overhaul-WPB-6647 October 2, 2024 13:48
@echoes-hq echoes-hq bot added echoes: features End-user visible changes intended to create customer value echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes: technical-debt Changes intended at mitigating risks labels Oct 2, 2024
@caldrian caldrian force-pushed the fix/double-column-split-view-in-portrait-WPB-10140 branch from fa57718 to a1c59ad Compare October 2, 2024 13:50
@caldrian caldrian merged commit 568b3c6 into epic/navigation-overhaul-WPB-6647 Oct 2, 2024
5 of 8 checks passed
@caldrian caldrian deleted the fix/double-column-split-view-in-portrait-WPB-10140 branch October 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes: technical-debt Changes intended at mitigating risks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant