Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace custom split view controller by UISplitViewController - WPB-9727 #1699

Merged
merged 576 commits into from
Sep 27, 2024
Merged

chore: replace custom split view controller by UISplitViewController - WPB-9727 #1699

merged 576 commits into from
Sep 27, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jul 16, 2024 •
edited by github-actions bot
Loading

TaskWPB-9727 Implement UISplitViewController for iPad

This PR only updates the epic branch with required changes so that the work can be continued on the epic branch itself.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@caldrian caldrian added the WIP label Jul 16, 2024
@caldrian caldrian force-pushed the chore/use-uisplitviewcontroller-WPB-9727 branch 2 times, most recently from 6c5b9eb to a4956ab Compare July 18, 2024 21:28
@caldrian caldrian changed the base branch from develop to chore/remove-spinnercapable-WPB-7306 July 30, 2024 15:01
Base automatically changed from chore/remove-spinnercapable-WPB-7306 to develop July 30, 2024 16:44
@caldrian caldrian force-pushed the chore/use-uisplitviewcontroller-WPB-9727 branch from f26819e to 1906864 Compare August 13, 2024 12:39
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 14, 2024
@caldrian caldrian changed the base branch from develop to chore/remove-main-storyboard-WPB-9727 August 15, 2024 17:22
@caldrian caldrian changed the base branch from chore/remove-main-storyboard-WPB-9727 to chore/container-view-controller-delegates-WPB-9727 August 16, 2024 11:25
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Aug 16, 2024
Base automatically changed from chore/container-view-controller-delegates-WPB-9727 to develop August 19, 2024 09:17
@caldrian caldrian changed the base branch from develop to chore/remove-rootviewcontroller-WPB-9727 August 20, 2024 09:43
@caldrian caldrian changed the base branch from chore/remove-rootviewcontroller-WPB-9727 to epic/navigation-overhaul-WPB-6647 August 20, 2024 14:53
@echoes-hq echoes-hq bot added the echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements label Aug 30, 2024
@caldrian caldrian force-pushed the chore/use-uisplitviewcontroller-WPB-9727 branch 2 times, most recently from e50a66b to 54ab21a Compare September 10, 2024 06:30
@caldrian caldrian force-pushed the chore/use-uisplitviewcontroller-WPB-9727 branch from 8fe0a6a to a9e8839 Compare September 13, 2024 09:47
@echoes-hq echoes-hq bot added the echoes: technical-debt Changes intended at mitigating risks label Sep 13, 2024
@caldrian
Merge branch 'feat/create-mainsplitviewcontroller-WPB-9727' into chor…
969e352 
…e/use-uisplitviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-sidebar-WPB-9727' into feat/create-mainspli…
f98c0bc 
…tviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-mainsplitviewcontroller-WPB-9727' into chor…
dd16acb 
…e/use-uisplitviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-sidebar-WPB-9727' into feat/create-mainspli…
cc06b8a 
…tviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-mainsplitviewcontroller-WPB-9727' into chor…
98c8dc7 
…e/use-uisplitviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-sidebar-WPB-9727' into feat/create-mainspli…
21d02ee 
…tviewcontroller-WPB-9727
@caldrian
erge branch 'feat/create-mainsplitviewcontroller-WPB-9727' into chore…
0506f81 
…/use-uisplitviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-sidebar-WPB-9727' into feat/create-mainspli…
6c13d07 
…tviewcontroller-WPB-9727
@caldrian
Merge branch 'feat/create-sidebar-WPB-9727' into feat/create-mainspli…
280e64c 
…tviewcontroller-WPB-9727
@caldrian caldrian changed the base branch from feat/create-mainsplitviewcontroller-no-WPB-10903 to epic/navigation-overhaul-WPB-6647 September 26, 2024 08:08
@caldrian caldrian added WIP and removed echoes: technical-debt Changes intended at mitigating risks echoes: features End-user visible changes intended to create customer value echoes: bugs Technical or functional defects in the product echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes/initiative: ios-sync-refactoring labels Sep 26, 2024
@caldrian caldrian marked this pull request as ready for review September 26, 2024 08:08
@echoes-hq echoes-hq bot added echoes: bugs Technical or functional defects in the product echoes: features End-user visible changes intended to create customer value echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes: technical-debt Changes intended at mitigating risks echoes/initiative: ios-sync-refactoring labels Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

Test Results

    6 files    386 suites   8m 39s ⏱️
3 637 tests 3 635 ✅ 0 💤 2 ❌
3 640 runs  3 636 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 248ab60.

♻️ This comment has been updated with latest results.

github-actions bot and others added 12 commits September 26, 2024 09:24
@github-actions @netbe
fix: user property read receipt with apiVersion v6 - WPB-11262 (#1966)
6de3fb4 
Co-authored-by: François Benaiteau <[email protected]>
Co-authored-by: François Benaiteau <[email protected]>
@caldrian
format code
e79245e
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/use-…
0c54f98 
…uisplitviewcontroller-WPB-9727
@caldrian
fix snapshot tests
8ff1029
@caldrian
minor fixes
948dbb7
@samwyndham
fix: Biometrics app lock - WPB-11014 (#1956)
994f3d9
@github-actions @KaterinaWire
feat: Remove call to deleteSubConversation after ending a 1:1 SFT cal…
3347c70 
…l - WPB-11123 (#1946)

Co-authored-by: KaterinaWire <[email protected]>
Co-authored-by: KaterinaWire <[email protected]>
@caldrian
fix: appearance of the main tab bar controller - WPB-9727 (#1971)
0677b40
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/use-…
9371760 
…uisplitviewcontroller-WPB-9727
@caldrian
Merge remote-tracking branch 'github/gh-readonly-queue/develop/pr-197…
248ab60 
…1-3347c704689a40d6d00618c01a3482b998957495' into chore/use-uisplitviewcontroller-WPB-9727

# Conflicts:
#	wire-ios/Wire-iOS/Sources/UserInterface/MainController/ZClientViewController.swift
@caldrian
optimize Package.swift
ae458c1
@caldrian
fix sidebar tinting
f335d74
@caldrian caldrian merged commit 509f19f into epic/navigation-overhaul-WPB-6647 Sep 27, 2024
6 of 11 checks passed
@caldrian caldrian deleted the chore/use-uisplitviewcontroller-WPB-9727 branch September 27, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caldrian caldrian

Labels
echoes: bugs Technical or functional defects in the product echoes: features End-user visible changes intended to create customer value echoes/initiative: ios-sync-refactoring echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes: technical-debt Changes intended at mitigating risks Navigation Overhaul WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caldrian @jullianm @johnxnguyen @samwyndham @agisilaos