fix: Hardening “About Wire” window (WEBAPP-4478) #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Nov 10, 2017
ghost
commented
- Now using Electron sandbox, preload script, ipc, nodeIntegration on false and javascript is also disabled on rendered page
- Prevent dropping links / following any kind of links but
- Only allow https:// links to be opened in the user browser (Chrome, Edge, FF…)
- Prevent the window from being minimized/maximized
- Always put the window on top of the other windows
- Typos
- Now using Electron sandbox, preload script, ipc, nodeIntegration on false and javascript is also disabled on rendered page - Prevent dropping links / following any kind of links but - Only allow https:// links to be opened in the user browser (Chrome, Edge, FF…) - Prevent the window from being minimized/maximized - Always put the window on top of the other windows - Typos
ghost
requested review from
ghost
changed the title
added 2 commits
November 10, 2017 18:17
lipis
reviewed
Nov 13, 2017
electron/main.js
Outdated
| @@ -24,12 +24,17 @@ const fs = require('fs-extra'); | |||
| const minimist = require('minimist'); | |||
| const path = require('path'); | |||
| const raygun = require('raygun'); | |||
| const { app, BrowserWindow, ipcMain, Menu, shell } = require('electron'); | |||
| const { session, app, BrowserWindow, ipcMain, Menu, shell } = require('electron'); | |||
There was a problem hiding this comment.
no bracket spacing and put the contents in alphabetical order
lipis
reviewed
Nov 13, 2017
electron/main.js
Outdated
| title: config.NAME, | ||
| width: config.WINDOW.ABOUT.WIDTH, | ||
| backgroundColor: '#ececec', | ||
| webPreferences: { |
There was a problem hiding this comment.
sort all properties in alphabetical order
bennycode
approved these changes
Nov 13, 2017
gregor
suggested changes
Nov 13, 2017
electron/main.js
Outdated
| javascript: false, | ||
| nodeIntegration: false, | ||
| nodeIntegrationInWorker: false, | ||
| preload: path.join(APP_PATH, 'js', 'about.js'), |
There was a problem hiding this comment.
If this is now a preload file, this needs to be reflected in the name.
yarn.lock
Outdated
| @@ -0,0 +1,6619 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
gregor
reviewed
Nov 14, 2017
| @@ -14,3 +14,4 @@ app.asar | |||
| node_modules | |||
| npm-debug.log | |||
| Wire*.zip | |||
| yarn.lock | |||
There was a problem hiding this comment.
Alphabetical order if you really want to add it here.
gregor
changed the title
gregor
changed the title
gregor
approved these changes
Nov 15, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.