Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update teamId after migrating from personal to team account (WPB-12187) #3120

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 21, 2024

TaskWPB-12187 [Android] update team id cache when joining a team


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After migration from personal to team account, we need to store teamId and invalidate the cached value

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Test Results

3 305 tests  ±0   3 198 ✅ ±0   4m 58s ⏱️ -12s
  564 suites ±0     107 💤 ±0 
  564 files   ±0       0 ❌ ±0 

Results for commit 47b3abe. ± Comparison against base commit 08c0cff.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.03%. Comparing base (08c0cff) to head (47b3abe).

Files with missing lines Patch % Lines
.../com/wire/kalium/logic/data/user/UserRepository.kt 25.00% 3 Missing ⚠️
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 0.00% 2 Missing ⚠️
.../com/wire/kalium/logic/data/user/CreateUserTeam.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3120      +/-   ##
===========================================
- Coverage    54.03%   54.03%   -0.01%     
===========================================
  Files         1246     1246              
  Lines        36152    36161       +9     
  Branches      3656     3656              
===========================================
+ Hits         19534    19538       +4     
- Misses       15208    15212       +4     
- Partials      1410     1411       +1     
Files with missing lines Coverage Δ
...user/migration/MigrateFromPersonalToTeamUseCase.kt 100.00% <100.00%> (ø)
.../kotlin/com/wire/kalium/persistence/dao/UserDAO.kt 96.33% <ø> (ø)
.../com/wire/kalium/logic/data/user/CreateUserTeam.kt 0.00% <0.00%> (ø)
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 52.47% <0.00%> (-0.02%) ⬇️
.../com/wire/kalium/logic/data/user/UserRepository.kt 68.04% <25.00%> (-0.61%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c0cff...47b3abe. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-wireapp
Copy link

Datadog Report

Branch report: update-team-id-after-migratiom-to-team
Commit report: bd283cd
Test service: kalium-jvm

✅ 0 Failed, 3198 Passed, 107 Skipped, 36.49s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants