Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove self user creator [WPB-11559] #3118

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 21, 2024

StoryWPB-11559 [Android] Delete a group as admin

https://wearezeta.atlassian.net/browse/WPB-11559

What's new in this PR?

Issues

We dont need the selfUserCreator anymore as the constraints on deleting group have changes, and now we need to belong to the same team.

Merge after

Merge only after this is merged wireapp/wire-android#3652


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Test Results

3 305 tests  ±0   3 198 ✅ ±0   4m 58s ⏱️ -12s
  564 suites ±0     107 💤 ±0 
  564 files   ±0       0 ❌ ±0 

Results for commit 154c6b4. ± Comparison against base commit 08c0cff.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.03%. Comparing base (08c0cff) to head (154c6b4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3118   +/-   ##
========================================
  Coverage    54.03%   54.03%           
========================================
  Files         1246     1246           
  Lines        36152    36150    -2     
  Branches      3656     3655    -1     
========================================
- Hits         19534    19533    -1     
+ Misses       15208    15207    -1     
  Partials      1410     1410           
Files with missing lines Coverage Δ
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% <ø> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 57.97% <ø> (+0.12%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c0cff...154c6b4. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/remove-self-user-creator
Commit report: d666569
Test service: kalium-jvm

✅ 0 Failed, 3198 Passed, 107 Skipped, 35.8s Total Time

Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove it from the view where it is created

@m-zagorski
Copy link
Contributor Author

please also remove it from the view where it is created

should I also remove it from db?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants