-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove self user creator [WPB-11559] #3118
base: develop
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Bencher Report
Click to view all benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3118 +/- ##
========================================
Coverage 54.03% 54.03%
========================================
Files 1246 1246
Lines 36152 36150 -2
Branches 3656 3655 -1
========================================
- Hits 19534 19533 -1
+ Misses 15208 15207 -1
Partials 1410 1410
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3198 Passed, 107 Skipped, 35.8s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also remove it from the view where it is created
should I also remove it from db? |
https://wearezeta.atlassian.net/browse/WPB-11559
What's new in this PR?
Issues
We dont need the selfUserCreator anymore as the constraints on deleting group have changes, and now we need to belong to the same team.
Merge after
Merge only after this is merged wireapp/wire-android#3652
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.