Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create backup protobuf models [WPB-10575] #3116

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Nov 20, 2024

StoryWPB-10575 Cross Platform Backup: Write common backup / restore library


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to (de)serialize data when storing backups.

Solutions

Use protobufs.
The idea here is to leverage the current protobuf generation and just build on top of it for backups.

When we upgrade to Kotlin 2.0+ we could replace PBandK and use KotlinX serialization for this. Unfortunately we're not there yet :'(

Notes

This is an initial / draft version that will be expanded in future PRs.

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Test Results

3 305 tests  ±0   3 198 ✅ ±0   4m 27s ⏱️ -43s
  564 suites ±0     107 💤 ±0 
  564 files   ±0       0 ❌ ±0 

Results for commit cc93964. ± Comparison against base commit 08c0cff.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.03%. Comparing base (08c0cff) to head (cc93964).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           epic/multiplatform-backup    #3116      +/-   ##
=============================================================
- Coverage                      54.03%   54.03%   -0.01%     
=============================================================
  Files                           1246     1246              
  Lines                          36152    36152              
  Branches                        3656     3656              
=============================================================
- Hits                           19534    19533       -1     
  Misses                         15208    15208              
- Partials                        1410     1411       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c0cff...cc93964. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/add-protobuf-models-for-backup
Commit report: 87f4bc0
Test service: kalium-jvm

✅ 0 Failed, 3198 Passed, 107 Skipped, 29.69s Total Time

@vitorhugods vitorhugods merged commit 1a57f5d into epic/multiplatform-backup Nov 22, 2024
27 checks passed
@vitorhugods vitorhugods deleted the chore/add-protobuf-models-for-backup branch November 22, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants