Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Recently ended call metadata [WPB-14256] #3112

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 20, 2024

StoryWPB-14256 [Android] Call end - Event and segmentation

https://wearezeta.atlassian.net/browse/WPB-14256

What's new in this PR?

Issues

We need to add Call ended segementation

Causes (Optional)

We need raw end call cause and a lot of data. In this PR we're storing recently ended call and give an use case
to create the metadata. I've also have the compact version of it (I will link it shortly) that is creating the metadata right away.

Solutions

Pick up all the things we need, prepare metadata and allow clients to observe them to use them in the analytics


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@m-zagorski m-zagorski changed the title Feat/recently ended call metadata feat: Rcently ended call metadata [WPB-14256] Nov 20, 2024
@m-zagorski m-zagorski changed the title feat: Rcently ended call metadata [WPB-14256] feat: Recently ended call metadata [WPB-14256] Nov 20, 2024
callMetadata: CallMetadata,
callEndReason: Int
) {
_recentlyEndedCallFlow.tryEmit(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also check #3113 as this changes this solution to a more compact which does not expose that much

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Test Results

3 294 tests  +5   3 187 ✅ +5   4m 49s ⏱️ -21s
  562 suites +1     107 💤 ±0 
  562 files   +1       0 ❌ ±0 

Results for commit 5c89646. ± Comparison against base commit 3bf74f0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 20, 2024

Datadog Report

Branch report: feat/recently-ended-call-metadata
Commit report: 3f1f070
Test service: kalium-jvm

✅ 0 Failed, 3187 Passed, 107 Skipped, 35.53s Total Time

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 37.63441% with 58 lines in your changes missing coverage. Please review.

Project coverage is 54.02%. Comparing base (eb66288) to head (5c89646).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../com/wire/kalium/logic/data/call/CallRepository.kt 8.69% 21 Missing ⚠️
...alium/logic/data/call/RecentlyEndedCallMetadata.kt 0.00% 19 Missing ⚠️
...all/usecase/GetRecentlyEndedCallMetadataUseCase.kt 75.00% 1 Missing and 7 partials ⚠️
...m/wire/kalium/logic/data/call/RecentlyEndedCall.kt 0.00% 3 Missing ⚠️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% 3 Missing ⚠️
...re/call/usecase/ObserveRecentlyEndedCallUseCase.kt 0.00% 3 Missing ⚠️
...om/wire/kalium/logic/feature/search/SearchScope.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3112      +/-   ##
===========================================
- Coverage    54.20%   54.02%   -0.18%     
===========================================
  Files         1205     1236      +31     
  Lines        35806    36095     +289     
  Branches      3641     3665      +24     
===========================================
+ Hits         19410    19502      +92     
- Misses       14993    15178     +185     
- Partials      1403     1415      +12     
Files with missing lines Coverage Δ
.../kalium/logic/feature/call/scenario/OnCloseCall.kt 88.23% <100.00%> (+4.14%) ⬆️
.../kalium/logic/feature/search/SearchUsersUseCase.kt 95.34% <100.00%> (ø)
...om/wire/kalium/logic/feature/search/SearchScope.kt 0.00% <0.00%> (ø)
...m/wire/kalium/logic/data/call/RecentlyEndedCall.kt 0.00% <0.00%> (ø)
...n/com/wire/kalium/logic/feature/call/CallsScope.kt 0.00% <0.00%> (ø)
...re/call/usecase/ObserveRecentlyEndedCallUseCase.kt 0.00% <0.00%> (ø)
...all/usecase/GetRecentlyEndedCallMetadataUseCase.kt 75.00% <75.00%> (ø)
...alium/logic/data/call/RecentlyEndedCallMetadata.kt 0.00% <0.00%> (ø)
.../com/wire/kalium/logic/data/call/CallRepository.kt 82.69% <8.69%> (-4.37%) ⬇️

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb66288...5c89646. Read the comment docs.

---- 🚨 Try these New Features:

Copy link

sonarcloud bot commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants