fix: offline connection request actions crash when unreachable #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnections requests
MohamadJaara
approved these changes
Sep 6, 2023
alexandreferris
approved these changes
Sep 6, 2023
Datadog ReportBranch report: ✅ |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…nnections requests (#2040)
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
* fix: field is optional for unreachable backends in some cases like connections requests (#2040) * Empty-Commit --------- Co-authored-by: Yamil Medina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Discovered in 06.09, playtest. Currently, the connection request endpoint does not respond with unreachable field, so there could be cases when unreachable could not be determined.
Causes (Optional)
Wrong behavior, as we need this exception to operate on connection request failure, ie: send, ignore, cancel.
Solutions
Mark the field as optional.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.