Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching tap-mssql to remove CVES and bumping to latest versions. #77

Merged
merged 27 commits into from
Aug 26, 2024

Conversation

s7clarke10
Copy link
Collaborator

@s7clarke10 s7clarke10 commented Aug 26, 2024

Patching tap-mssql to work with the latest versions of the pytest components. This is required to address CVES identified by dependabot.

tap-mssql 2.5.0 2024-08-26

  • removing tox-poetry-install - Not well supported and not required for the pipelines.
  • Updating integration tests variables to CAPS to support passing MSSQL Port
  • tox-docker requires expose rather than ports syntax in tox.ini
  • Bumping docker = "^6.1.3" -> "^7.1.0"
  • Bumping pytest = "^7.0.0" -> "^8.3.2"
  • Bumping pytest-cov = "^4.1.0" -> = "^5.0.0"
  • Bumping mypy = "^1.10.1" -> = "^1.11.1"
  • Bumping pytest-sugar = "^0.9.7" -> = "^1.0.0"
  • Bumping pytest-datafiles = "^2.0" -> = "^3.0"
  • Bumping tox-docker = "4.1.0" -> = "5.0.0"
  • Bumping requests = "2.31.0" -> "2.32.3"
  • Bumping tox = "^3.28.0" -> "^4.18.0"

Local testing has been as well as the integration testing to ensure the tap-mssql application still works correctly.

@s7clarke10 s7clarke10 requested a review from mjsqu August 26, 2024 04:16
@s7clarke10 s7clarke10 self-assigned this Aug 26, 2024
Copy link
Collaborator

@mjsqu mjsqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - no introduced or removed functionality, satisfied that this is a dependencies-only change

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff in this file must have been affected by line-endings or whitespace. Hard to see the actual changes, but I have checked line-by-line and all looks ok

@s7clarke10 s7clarke10 merged commit a1132ad into wintersrd:master Aug 26, 2024
1 check passed
@s7clarke10 s7clarke10 deleted the feature/patch_cves_20240822 branch October 17, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants