Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove escape percent signs from select_sql #16

Closed
wants to merge 4 commits into from
Closed

remove escape percent signs from select_sql #16

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d1586e
remove escape percent signs from select_sql
dgoo2308 Aug 1, 2021
88a695e
Merge branch 'wintersrd:master' into fix_double%%
dgoo2308 Jul 31, 2022
b714e81
add the missing deleted 'return select_sql'
dgoo2308 Jul 31, 2022
f5923a5
Merge branch 'master' into fix_double%%
dgoo2308 Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tap_mssql/sync_strategies/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,7 @@ def generate_select_sql(catalog_entry, columns):
escaped_columns = [escape(c) for c in columns]

select_sql = "SELECT {} FROM {}.{}".format(",".join(escaped_columns), escaped_db, escaped_table)

# escape percent signs
select_sql = select_sql.replace("%", "%%")
return select_sql



dgoo2308 marked this conversation as resolved.
Show resolved Hide resolved
def row_to_singer_record(catalog_entry, version, row, columns, time_extracted):
row_to_persist = ()
for idx, elem in enumerate(row):
Expand Down