-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path enumerable trait #155
base: develop
Are you sure you want to change the base?
Conversation
Implements path enumeration hierarchy for models, operating similar to nested set models but not requiring the rigid left/right values.
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This allows the path to be made up of segments from a different field, such as folder, or name. By default, path segments are derived from the primary key (usually an ID).
@bennothommo let me know when you want me to review this! |
@LukeTowers it's good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @bennothommo, targeting next release pending docs PR for this feature :)
@bennothommo is there a docs PR for this? |
@LukeTowers not yet - I'm toying with the idea of unifying the tree traits in some fashion so they share a common base level of functionality and API. |
@bennothommo is that something that needs to happen now or could we move forward with merging this so that we can get metadata support added to the Media Library? |
@LukeTowers my concern is that we'll have difficulty changing the API later. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
@bennothommo status on this? |
Just waiting for docs. I mentioned previously trying to attempt to unify the tree APIs, but I probably won't do it for this branch. It might be worth looking into next major release. |
@bennothommo sounds good to me, lets get the docs done up so we can roll this into the next release then. Would be nice to make some progress on the media library metadata. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
@bennothommo ping |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
Implements path enumeration hierarchy for models, operating similar to nested set models but not requiring the rigid left/right values.
This is in preparation for some work towards database storage of media items.