Initial WIP on improving the File model to use more native disk methods

[LukeTowers]

WIP

[what-the-diff]

• Added a constant DISK to the class.
• Changed fromPost and fromFile methods return type hinting static instead of void, also added nullable types for parameters in both functions.
• Removed unused setDataAttribute method as it is not used anywhere else in the codebase or called by any other classes/methods etc...
  5-6: Fixed typos within comments above each function where 'return' was spelt incorrectly as 'retunr'. This has since been fixed correctly now though :)

[Denoder]

Could you consider changing the width and height attribute to be optional when using an s3 driver in some form. These 2 attributes make any remote storage take more than 7 seconds because it has to download the file locally.

[Denoder]

actually nvm, I can just override it

[LukeTowers]

We could store that data on upload theoretically and retrieve it from metadata instead of recalculating

[Denoder]

hmm, if that's the case, wouldn't it also be beneficial to have a has_thumb meta parameter to indicate if the image has a thumbnail or not.

Currently the way I have it is that I have a has_thumb property on the file model. so rather than using hasFile which checks the remote file location it checks if that parameter is set, then I offload the thumbnail generation to a queue (this is more of a custom solution for me that im utilizing, but using hasFile slows down the process a lot.)

[LukeTowers]

We should probably add a metadata column in the form of a JSON blob to store this sort of information

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.