Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sassdown should be decoupled from Grunt #83

Open
winstromming opened this issue Mar 4, 2015 · 7 comments
Open

Sassdown should be decoupled from Grunt #83

winstromming opened this issue Mar 4, 2015 · 7 comments
Assignees
Milestone

Comments

@winstromming
Copy link
Owner

Problem:

  • Sassdown uses grunt methods such as grunt.file.read, grunt.verbose.write, etc. This added dependency makes writing a caller-agnostic module more difficult.

Objective:

  • Replace any required methods with other, dedicated third-party modules or core methods if possible. (eg. node-glob, fs-extra, etc.)
@dwightjack
Copy link
Contributor

Hi,

I've read a couple of issue about this topic. I'm moving some of my project from grunt to gulp and, since i'm using sassdown and find it very usefull, I'd like to know if I can help in any way.

I'm pretty experienced in JS/Grunt and a bit in node. Never did a gulp-capable module though...

Bye!

@dwightjack
Copy link
Contributor

Hi I've managed to remove grunt deps.

The codebase is still a bit raw, but tests output is the same as the grunt version:

https://github.com/fevrcoding/node-sassdown

@dwightjack
Copy link
Contributor

Sorry for the multiple posts.

Here is the wrapped grunt plugin:

https://github.com/fevrcoding/grunt-sassdown

@winstromming
Copy link
Owner Author

Hi, @dwightjack - thanks for your contribution on this. Have you looked at the 1.0.0 branch? I've done quite a bit of this already. https://github.com/nopr/sassdown/tree/feature/1.0.0

@dwightjack
Copy link
Contributor

Ops, sorry

didn't had any feedback on this issue so i thought to contribute.

I'll take a look to 1.0.0 and contribute on that :)

@Trolleymusic
Copy link

👍 This would be a useful feature. I'll use grunt.loadNpmTasks in the meantime 💅

@dwightjack
Copy link
Contributor

Hi I took a look at the codebase.
I'm not sure using the context of module.exports as instance configuration options is a good idea. It's an edge case, I think, but if someone wants to use the library twice he will end up sharing all the settings.

I think a better solution would be to use a constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants