Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp.js support #35

Open
VinSpee opened this issue Jan 31, 2014 · 10 comments
Open

gulp.js support #35

VinSpee opened this issue Jan 31, 2014 · 10 comments
Assignees
Labels

Comments

@VinSpee
Copy link

VinSpee commented Jan 31, 2014

I know, I know. But it is really cool and I'd love to use sassdown with it.

@winstromming
Copy link
Owner

I've branched the project and will be looking into either dedicated gulpjs support or restructuring to not require Grunt, specifically. Thanks for suggesting this.

@ghost ghost assigned winstromming Feb 2, 2014
@VinSpee
Copy link
Author

VinSpee commented Feb 2, 2014

Awesome! Looking forward to it.

On Sun, Feb 2, 2014 at 10:12 AM, Jesper Hills [email protected]
wrote:

I've branched the project and will be looking into either dedicated gulpjs support or restructuring to not require Grunt, specifically. Thanks for suggesting this.

Reply to this email directly or view it on GitHub:
#35 (comment)

@VinSpee
Copy link
Author

VinSpee commented Mar 27, 2014

does this branch exist anywhere so I can maybe help?

@winstromming
Copy link
Owner

I didn't get around to doing much on this; life took over. I'm happy to merge a pull request if you're able to crack it though!

@KennethSundqvist
Copy link
Contributor

I want to look into this because I need it too.

I'm thinking the solution to not require Grunt is better so that:

  • it gets attention and is usable by people not using Grunt
  • it can be used anywhere using its API directly or by writing wrappers that uses its API (like a Grunt wrapper)

If we do that refactoring I think Sassdown could be usable directly in a Gulp task.

What do you think?

@mdix
Copy link
Contributor

mdix commented Nov 6, 2014

Hi,

I'd see the following action points:

  • remove grunt from this plugin
  • start a grunt-sassdown repo and use sassdown (this repo) as a dependency
  • start a gulp-sassdown repo and use sassdown (this repo) as a dependency

I'd suggest use 0.3 as version number, as node adds the caret when installing with npm install sassdown (currently its "sassdown": "^0.2.7" what means that all people using sassdown with grunt support included will get the 0.2.x version instead (and you might also push bugfixes for the old version).

What you think, @NoPr?

Best
Marc

@winstromming
Copy link
Owner

@mdix

I'm in agreement with removing grunt from this plugin. Ultimately, I don't think it's necessary. When I started writing Sassdown I was very new to both Grunt and node.js development; it was a crutch. Going forwards I would like to make Sassdown a standalone node module so that both Grunt/Gulp can be used or -- if desired -- neither.

Having grown and developed my skills in both node and javascript over the last couple of years, I'm slowly finding more and more issues with the current implementation of Sassdown. It could be more modular. It could be faster. It could be more portable. It could be more customisable. It could be more useful. In addition, other modules have come forward that aim to do exactly what Sassdown tried to accomplish.

I don't meant to say that Sassdown is redundant. But at this point I strongly feel that it requires a large re-write in order to become more relevant. I've been putting this off for too long.

@mdix
Copy link
Contributor

mdix commented Nov 6, 2014

Hi @NoPr,

I don't think the way you think. I mean - sassdown works (most of the time, hehe - 0.2.6 vs. 0.2.7), the code is okay (it could really be worse!) and we could easily make it work with grunt and gulp. Why not doing so? You can say you WANT to rewrite it, but I guess you put it off for too long because you had no time to maintain. Is it really realistic that you find time to rewrite it?

Let's just remove the grunt binding and add two repos with grunt-sassdown and gulp-sassdown, so that ppl. can use it with both tools. It's not much work and extends the userbase (quickwin!). If you find time to rewrite it, you can silently replace the existing sassdown with your rewritten version.

Some Questions aside: Did someone complain that it's too slow? Did someone complain that it's not modular enough? People use it because it works for them. So what? C'mon Jesper. Nobody is perfect, and so is software. :)

Best
Marc

@tbredin
Copy link

tbredin commented Sep 23, 2015

Where did this one end up?

@matheusbaumgart
Copy link

I'm also interested to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants