Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transports.js #731

Closed
wants to merge 2 commits into from
Closed

Update transports.js #731

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b76c0
Update transports.js
jwulf Oct 21, 2015
0f4dbdd
Update transports.js
jwulf Oct 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 27 additions & 20 deletions lib/winston/transports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,30 @@ var fs = require('fs'),

var transports = exports;

//
// Setup all transports as lazy-loaded getters.
//
fs.readdirSync(path.join(__dirname, 'transports')).forEach(function (file) {
var transport = file.replace('.js', ''),
name = common.capitalize(transport);

if (transport === 'transport') {
return;
}
else if (~transport.indexOf('-')) {
name = transport.split('-').map(function (part) {
return common.capitalize(part);
}).join('');
}

transports.__defineGetter__(name, function () {
return require('./transports/' + transport)[name];
});
});
transports.__defineGetter__('CONSOLE', function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing is wrong on all of these. Would be:

transports.__defineGetter__('Console', function () {

Also you should use Object.defineProperty not __defineGetter__

return require('./transports/console.js')[name];
});

transports.__defineGetter__('FILE', function () {
return require('./transports/file.js')[name];
});
transports.__defineGetter__('HTTP', function () {
return require('./transports/http.js')[name];
});

transports.__defineGetter__('MEMORY', function () {
return require('./transports/memory.js')[name];
});

transports.__defineGetter__('TRANSPORT', function () {
return require('./transports/transport.js')[name];
});

transports.__defineGetter__('WEBHOOK', function () {
return require('./transports/webhook.js')[name];
});

transports.__defineGetter__('DAILY-ROTATE-FILE', function () {
return require('./transports/daily-rotate-file.js')[name];
});