Remove LogCallback in ts definition files #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DABH
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
These changes seem fine per the issue linked in the PR description, but see the discussion in that issue - need to figure out if this goes in a major or minor release. A bit hesitant to do a major release for some TS changes, but perhaps it's ok to do this as a minor release if these TS definitions never worked?
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
LogCallback is not supported anymore as per version 3 and can cause confusion
https://github.com/winstonjs/winston/blob/HEAD/UPGRADE-3.0.md#winstonlogger
winston.Logger.log and level-specific methods (.info, .error, etc) no longer accepts a callback.
This PR removes the LogCallback types and its reference in LogLevelMethod and LogMethod interface
closes: #1922