Remove nonexistent Logger methods from types

[JavaScriptBach]

Remove nonexistent Logger methods from types. Fixes #2280

Testing

Welcome to Node.js v18.16.1.
Type ".help" for more information.
> const winston = require("winston")
undefined
> const logger = winston.createLogger({})
undefined
> logger.warning
undefined
> logger.emerg
undefined
> logger.alert
undefined
> logger.crit
undefined
> logger.notice
undefined

[wbt]

This PR removes some lines that were most recently moved in #1807 and moved back in #1820 due to #1817.
They were originally added in #1190, a broad PR adding TypeScript definitions, with notes warning about insufficient testing.
The proposed change looks good to me but I'll leave it open a bit for possible addition of regression tests and any other feedback, especially as this looks like it will cause some things to fail at transpile-time that previously would pass that and generally fail at runtime instead.

[JavaScriptBach]

With all due respect, I think you're overthinking this change. This PR only changes types, not runtime behavior, so there is nothing to regression test. And the whole point of types is catch broken code at compile time, instead of at runtime. The fact that the types currently 1) allow broken code to type check and 2) imply the existence of methods that don't exist is a bug that IMO should be fixed ASAP.

[provAlyssaKrueger]

@wbt any chance we can get the proposed fix merged?
The existing types are misleading and pose a risk for causing runtime errors.

At the very least, you should consider making the methods optional so a caller using TypeScript strict null checks is aware.

[codazzo]

Thanks for the fix @JavaScriptBach. @wbt would you consider releasing a new version of the package so users of the package can get it?

[derekdowling]

Hello @wbt can we please get a version release with this change? The incorrect typings just broke us in production.

[codazzo]

Perhaps @DABH could help with a new release?

[DABH]

I've just released winston v3.12.0. I hope this helps!

[wbt]

#2424 demonstrates the validity of being quite hesitant to merge!