Debugger fix #1835
Open
Debugger fix #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Console transport
|
The CI build error seems to be a windows line ending issue?
|
louisgv
reviewed
Feb 4, 2021
| @@ -30,7 +31,13 @@ module.exports = class Console extends TransportStream { | |||
| this.name = options.name || 'console'; | |||
| this.stderrLevels = this._stringArrayToSet(options.stderrLevels); | |||
| this.consoleWarnLevels = this._stringArrayToSet(options.consoleWarnLevels); | |||
| this.eol = options.eol || os.EOL; | |||
There was a problem hiding this comment.
I think you might need to either change the behavior of the eol tests that're failing to skip eol, or reimplement the eol for windows compat?
There was a problem hiding this comment.
Yes, it seems that Windows is using some non-standard line ending?
There was a problem hiding this comment.
Yes - windows uses \r\n instead of \n for new line, thus broke the test above
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544, and does so more reliably than #1798 , even with overridden console, or individual console methods