Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the code example fully executable #1677

Merged
merged 1 commit into from Aug 15, 2019
Merged

Made the code example fully executable #1677

merged 1 commit into from Aug 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 26, 2019

Because of the missing require statement when copy & paste the code example the code didn't work. This commit changes this.

Because of the missing require statement when copy & paste the code example the code didn't work. This commit changes this.
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since so many other examples in the readme have the require, I guess this one should, too. thanks.

@DABH DABH merged commit e325793 into winstonjs:master Aug 15, 2019
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
Because of the missing require statement when copy & paste the code example the code didn't work. This commit changes this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant