-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rejectionHandlers type definition does not exist #1801
Comments
this functionality does not seem to be working at all |
The fix should be as simple as adding this one line in the index.d.ts so that the compiler can recognize it. |
leonardehrenfried
added a commit
to leonardehrenfried/winston
that referenced
this issue
Oct 28, 2020
This was referenced Oct 28, 2020
Issue still exists |
vanflux
added a commit
to vanflux/winston
that referenced
this issue
Jan 11, 2022
The 'rejectionHandlers' field was missing on LoggerOptions interface at index.d.ts. Issue: winstonjs#1801
fearphage
pushed a commit
that referenced
this issue
Jan 13, 2022
* RejectionHandlers added to LoggerOptions The 'rejectionHandlers' field was missing on LoggerOptions interface at index.d.ts. Issue: #1801 * Added handleRejections field to LoggerOptions. A complement to rejectionHandlers commit. * Added RejectionHandler to Logger interface Added RejectionHandler to Logger interface, Basically the same of PR: #1929 Suggest by: #2021 (comment)
Merged
Looks like this is merged now so I'm going to close out this issue. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please tell us about your environment:
winston
version?winston@2
winston@3
What is the problem?
In the
index.d.ts
type defeintions of RejectionHandler does not exist. Neither does the rejectionHandler option inLoggerOptions
winston/index.d.ts
Line 77 in 9354721
What do you expect to happen instead?
Since this is an actual feature of this library (see below), expectation is it is typed and available to typescript users
winston/lib/winston.js
Line 58 in 9354721
The text was updated successfully, but these errors were encountered: