Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParseError::with_input #604

Closed

Conversation

9999years
Copy link
Contributor

@9999years 9999years commented Oct 14, 2024

This lets you replace the input field in a ParseError, e.g. to transform a ParseError<&str, E> into a ParseError<String, E>. I'd like this so that I can have an owned ParseError type, but only if a top-level parse fails.

This lets you replace the input field in a `ParseError`, e.g. to
transform a `ParseError<&str, E>` into a `ParseError<String, E>`.
@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 11334127920

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 41.568%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/error.rs 1 4 25.0%
Totals Coverage Status
Change from base Build 11107240362: -0.04%
Covered Lines: 1299
Relevant Lines: 3125

💛 - Coveralls

@epage
Copy link
Collaborator

epage commented Oct 14, 2024

We ask that new features start as issues to explore the underlying use case and requirements and then discuss how we want to solve the problem. We then move onto PRs to discuss the implementation.

@epage epage closed this Oct 14, 2024
@9999years
Copy link
Contributor Author

Done: #606

I now see that you also told me to open an issue first (quite kindly) on #541 — apologies for making the same mistake twice. I assumed the change was small enough to be uncontroversial, but I can respect having all changes go through the same process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants