-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): cant call fromJson on imported structs #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasanaburayyan
changed the title
feat(compiler): support fromJson on imported structs
fix(compiler): cant call fromJson on imported structs
Aug 23, 2023
Signed-off-by: monada-bot[bot] <[email protected]>
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
PR has been mutated and will not auto-merge. Clear this label if the changes look good!
label
Aug 23, 2023
MarkMcCulloh
removed
the
⚠️ pr/review-mutation
PR has been mutated and will not auto-merge. Clear this label if the changes look good!
label
Aug 24, 2023
eladb
reviewed
Aug 24, 2023
MarkMcCulloh
approved these changes
Aug 24, 2023
Thanks for contributing, @hasanaburayyan! This PR will now be added to the merge queue, or immediately merged if |
10 tasks
Congrats! 🚀 This was released in Wing 0.25.45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3792
Now supports calling fromJson on structs that were brought from other wing files
example:
file_1.w
file_2.w
Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.