feat(server): remove ability to add a socket fd

This is currently not used by any consumer. In theory it could be useful for
implementing the new security context protocol. But once we implement this we
may readd it or do it a different way.

But in any case also creating the wl_display when adding a socket is a somewhat
confusing API interface. So if any we should do it differently in the future.

BREAKING CHANGE: Display::add_socket_fd removed

server/display.cpp

@@ -123,11 +123,6 @@ std::string Display::socket_name() const
     return d_ptr->socket_name;
 }
 
-void Display::add_socket_fd(int fd)
-{
-    d_ptr->add_socket_fd(fd);
-}
-
 void Display::start(StartMode mode)
 {
     d_ptr->start(mode == StartMode::ConnectToSocket);

server/display.h

@@ -108,8 +108,6 @@ class WRAPLANDSERVER_EXPORT Display : public QObject
     wl_display* native() const;
     bool running() const;
 
-    void add_socket_fd(int fd);
-
     void createShm();
 
     void dispatch();

server/wayland/display.cpp

@@ -78,17 +78,6 @@ wl_display* Display::native() const
     return m_display;
 }
 
-void Display::add_socket_fd(int fd)
-{
-    if (!m_display) {
-        m_display = wl_display_create();
-    }
-
-    if (wl_display_add_socket_fd(m_display, fd)) {
-        qCWarning(WRAPLAND_SERVER, "Failed to add fd %d.", fd);
-    }
-}
-
 bool Display::running() const
 {
     return m_running;

server/wayland/display.h

@@ -49,8 +49,6 @@ class Display
     explicit Display(Server::Display* handle);
     virtual ~Display();
 
-    void add_socket_fd(int fd);
-
     void addGlobal(BasicNucleus* nucleus);
     void removeGlobal(BasicNucleus* nucleus);