WINDUPRULE-945 JavaEE to Quarkus: helloworld-rs migration #1
Conversation
| @@ -29,7 +29,6 @@ | |||
| <relativePath>../pom.xml</relativePath> | |||
| </parent> | |||
| <artifactId>helloworld-rs</artifactId> | |||
| <packaging>war</packaging> | |||
There was a problem hiding this comment.
The expected project artifact's extension is jar
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>${quarkus.platform.group-id}</groupId> | ||
| <artifactId>${quarkus.platform.artifact-id}</artifactId> | ||
| <version>${quarkus.platform.version}</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> |
There was a problem hiding this comment.
Adopt Quarkus BOM
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id> | ||
| <quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id> | ||
| <quarkus.platform.version>2.16.6.Final</quarkus.platform.version> |
There was a problem hiding this comment.
Adopt Quarkus BOM
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <plugin> | ||
| <groupId>${quarkus.platform.group-id}</groupId> | ||
| <artifactId>quarkus-maven-plugin</artifactId> | ||
| <version>${quarkus.platform.version}</version> | ||
| <extensions>true</extensions> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>build</goal> | ||
| <goal>generate-code</goal> | ||
| <goal>generate-code-tests</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
Adopt Quarkus Maven plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>${compiler-plugin.version}</version> | ||
| <configuration> | ||
| <compilerArgs> | ||
| <arg>-parameters</arg> | ||
| </compilerArgs> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
Adopt Maven Compiler plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <plugin> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>${surefire-plugin.version}</version> | ||
| <configuration> | ||
| <systemPropertyVariables> | ||
| <java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager> | ||
| <maven.home>${maven.home}</maven.home> | ||
| </systemPropertyVariables> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
Adopt Maven Surefire plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id> | ||
| <quarkus.platform.version>2.16.6.Final</quarkus.platform.version> | ||
| <skipITs>true</skipITs> | ||
| <surefire-plugin.version>3.0.0</surefire-plugin.version> |
There was a problem hiding this comment.
Adopt Maven Surefire plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <compiler-plugin.version>3.10.1</compiler-plugin.version> | ||
| <maven.compiler.release>11</maven.compiler.release> |
There was a problem hiding this comment.
Adopt Maven Compiler plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <plugin> | ||
| <artifactId>maven-failsafe-plugin</artifactId> | ||
| <version>${surefire-plugin.version}</version> | ||
| <executions> | ||
| <execution> | ||
| <goals> | ||
| <goal>integration-test</goal> | ||
| <goal>verify</goal> | ||
| </goals> | ||
| <configuration> | ||
| <systemPropertyVariables> | ||
| <native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path> | ||
| <java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager> | ||
| <maven.home>${maven.home}</maven.home> | ||
| </systemPropertyVariables> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> |
There was a problem hiding this comment.
Adopt Maven Failsafe plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <profiles> | ||
| <profile> | ||
| <id>native</id> | ||
| <activation> | ||
| <property> | ||
| <name>native</name> | ||
| </property> | ||
| </activation> | ||
| <properties> | ||
| <skipITs>false</skipITs> | ||
| <quarkus.package.type>native</quarkus.package.type> | ||
| </properties> | ||
| </profile> | ||
| </profiles> |
There was a problem hiding this comment.
Add Maven profile to run the Quarkus native build
https://quarkus.io/guides/maven-tooling#build-tool-maven
| <groupId>org.jboss.spec.javax.ws.rs</groupId> | ||
| <artifactId>jboss-jaxrs-api_2.1_spec</artifactId> | ||
| <scope>provided</scope> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-resteasy</artifactId> |
There was a problem hiding this comment.
Replace JAX-RS dependency
https://quarkus.io/guides/resteasy
There was a problem hiding this comment.
should use quarkus-resteasy-reactive if possible.
might be edge cases of things in resteasy/jaxrs we don't support but quarkus-resteas-reactive would be recommended if intent is to move forward vs staying more compatible.
| <groupId>javax.enterprise</groupId> | ||
| <artifactId>cdi-api</artifactId> | ||
| <scope>provided</scope> | ||
| <groupId>io.quarkus</groupId> | ||
| <artifactId>quarkus-arc</artifactId> |
There was a problem hiding this comment.
Replace javax.enterprise:cdi-api dependency
https://quarkus.io/guides/cdi-reference
| /** | ||
| * A simple CDI service which is able to say hello to someone | ||
| * | ||
| * @author Pete Muir | ||
| * | ||
| */ | ||
| @Dependent |
There was a problem hiding this comment.
Injected class is missing scope annotation
https://quarkus.io/guides/cdi-reference
https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#default_scope
| @@ -16,12 +16,15 @@ | |||
| */ | |||
| package org.jboss.as.quickstarts.rshelloworld; | |||
|
|
|||
| import javax.enterprise.context.Dependent; | |||
There was a problem hiding this comment.
Injected class is missing scope annotation
https://quarkus.io/guides/cdi-reference
https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#default_scope
There was a problem hiding this comment.
Static resources
https://quarkus.io/guides/http-reference#serving-static-resources
There was a problem hiding this comment.
beans.xml descriptor content is ignored
https://quarkus.io/guides/cdi-reference#limitations
Rules created from these changes in: