fix: update deno_core to latest to work better with rust 1.78 #3890
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 393fa99 in 2 minutes and 55 seconds
More details
- Looked at
1329lines of code in6files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/Cargo.toml:170
- Draft comment:
Ensure that thedeno_astversion inCargo.tomlmatches the updated version inCargo.lockto maintain consistency and avoid potential dependency resolution issues.
deno_ast = { version = "0.39.1", features = ["transpiling"] }
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_DI6NkFc0wwkIj3ay
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
f895ae1
|
| Status: | ⚡️ Build in progress... |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on a301b25 in 2 minutes and 1 seconds
More details
- Looked at
68lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_XukT4PwIXAecFOym
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -882,6 +922,55 @@ multiline template`"; | |||
| Ok(()) | |||
| } | |||
There was a problem hiding this comment.
The test function test_eval_timeout_bug initializes a Deno runtime but does not perform any operations or assertions with it, making it ineffective as a test. Consider adding relevant JavaScript code execution and assertions to validate the runtime behavior.
rubenfiszel
changed the title
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f895ae1 in 1 minute and 59 seconds
More details
- Looked at
139lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. backend/windmill-worker/src/js_eval.rs:779
- Draft comment:
The removal of Deno network and TLS module imports needs verification against updated Deno module changes to ensure continued functionality. - Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_hV4oEbxNQ7bD6ySX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
This PR updates dependencies, refines Deno integration, and enhances runtime setup in the
windmill-workermodule, with specific improvements in permissions handling and snapshot management.Key points:
Cargo.tomlfor backend andwindmill-worker.windmill-workerandjs_eval.rsto update Deno permissions handling.windmill-workerto align with updated Deno modules.windill-workerbuild script.Generated with ❤️ by ellipsis.dev