Reworked the overrides panel #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uously to match target feed and spindle speeds. Replaced override buttons with sliders.
…he feed and spindle speed overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced a new OverrideManager that will be responsible for handling all types of overrides for the controller. It will exist in a couple of flavors for different controllers and provide a unified interface for dealing with override operations.
For instance, the min and max feed override values may be differ between controller types.
The override panel will detect which controls it can present.
The override panel now has sliders for feed and spindle speed where the target value will be acheived by the OverrideManager:
Since the override values now can be given within an interval we can now also apply this with an analog input on a gamepad:
I have also disabled the override functionality on g2core as it is not (and has never been) working properly.