Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved the responsibility for parsing the command response from the communicator to the command #2190

Merged
merged 3 commits into from
Apr 1, 2023
Merged

Moved the responsibility for parsing the command response from the communicator to the command #2190

merged 3 commits into from
Apr 1, 2023

Commits on Apr 1, 2023

  1. Moved the responsibility for parsing the command response from the co… 

    …mmunicator to the command.

The commands will now parse the response and figure out if the command has been completed or not. This is especially important for multiline response commands. This also makes the communicators generic as it no longer contain protocol specific implementation.
    @breiler
    breiler committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    dc31261 View commit details
    Browse the repository at this point in the history

  2. Forgot to commit new files

    @breiler
    breiler committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    a4f9900 View commit details
    Browse the repository at this point in the history

  3. Fixed broken test

    @breiler
    breiler committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    90d7d57 View commit details
    Browse the repository at this point in the history