should fix jSerialComm hangs on MacOS #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of a common buffer, could result in rx data being lost during overlapping serial event calls updates jSerialComm to v2.9.2 (has many bug fixes since v2.6.2)
… calls to serialEvent
Codecov Report
@@ Coverage Diff @@
## master #1969 +/- ##
=========================================
Coverage 22.51% 22.51%
Complexity 1997 1997
=========================================
Files 577 577
Lines 24247 24244 -3
Branches 1922 1921 -1
=========================================
Hits 5459 5459
+ Misses 18317 18314 -3
Partials 471 471
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates jSerialComm to 2.9.2 (many bug fixes)
removes common rx buffer that could cause data loss if there were overlapping calls to serialEvent